A4A: avoid multiple agency creations when reloading signup page

[andrii-lysenko]

Related to pfSQfS-DM-p2

Proposed Changes

Currently, signup can work as follows:

• /signup where user fills the form and it got saved to localStorage
• auth on wpcom side
• /signup/finish where we check if there's data in local storage and submit mutation to create agency.

The problem now in this flow due to a corner case, where user can reload /signup/finish multiple times, thus submitting mutation multiple times.

To fix this, we will save a timestamp to localStorage at the time of mutation. Then, if page is reloaded we will not send any mutation within 1 minute of the original mutation. Instead, we will fetch the agency status every 5 seconds. If after 1 minute still no agency created, mutation will be done again.

Why are these changes being made?

Testing Instructions

• Using live link below, open in in Incognito window with /signup path
• Follow the signup flow
• After navigating to /signup/finish refresh the page multiple times
• Check network tab to see GET /agency requests.
• Verify using MC tool that only 1 agency is created for user.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129383

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129383&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129383&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug a4a/avoid-multiple-agency-creation-when-reloading-signup-page on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~311 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
a8c-for-agencies-signup      +1161 B  (+0.8%)     +311 B  (+0.7%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[andrii-lysenko]

We are postponing this change for now.