Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Plugin Management: Remove autoupdate label for all screen sizes #98161

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

epeicher
Copy link
Contributor

@epeicher epeicher commented Jan 9, 2025

Related to https://github.com/Automattic/dotcom-forge/issues/10216

Proposed Changes

  • It hides the label for Autoupdates as it is displayed for small screens
Before After
CleanShot 2025-01-09 at 17 08 25@2x CleanShot 2025-01-09 at 17 08 42@2x

Why are these changes being made?

  • That label is not required. It is there for a list visualization, but it does not apply to the current table visualization

Testing Instructions

  • Apply this patch and navigate to /plugins/manage
  • Select a plugin that is installed on some sites
  • Reduce the screen and check the Autoupdate label is not displayed
  • Check there are no visual regressions accessing the Jetpack Cloud link below and navigating to /plugins/manage/akismet for example

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                                +13 B  (+0.0%)       +5 B  (+0.0%)
jetpack-cloud-plugin-management        +13 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@epeicher epeicher self-assigned this Jan 9, 2025
@epeicher epeicher merged commit 2abae24 into trunk Jan 10, 2025
13 checks passed
@epeicher epeicher deleted the fix/plugin-list-activate-toggle-label branch January 10, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants