Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: add Summary 'Locations' path #98158

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

myhro
Copy link
Contributor

@myhro myhro commented Jan 9, 2025

Closes Automattic/jetpack-roadmap#2097.

Proposed Changes

  • Changes the Stats summary URL from /countryviews/ to /locations/.

Why are these changes being made?

  • (p1HpG7-rpL-p2)

Testing Instructions

  • Access the Calypso Live preview linked below.
  • Access the Stats page of a website that has meaningful data, like /stats/day/jetpack.com?flags=stats/locations
  • Scroll down to the map and click on the View all link after the locations list.
  • It should redirect to a link similar to /stats/day/locations/jetpack.com?startDate=2025-01-03&endDate=2025-01-09
    • Ensure the path contains /locations/ and NOT /countryviews/
  • The breadcrumbs on the same page should also say Locations instead of Countries.
Before After
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~22 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-calypso-my-sites-stats-summary       +272 B  (+0.6%)      +22 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@myhro myhro added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 9, 2025
@myhro myhro requested review from a team January 9, 2025 15:57
Copy link
Contributor

@mavegaf mavegaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@myhro myhro merged commit a4bd858 into trunk Jan 10, 2025
15 of 16 checks passed
@myhro myhro deleted the add/stats-summary-locations-path branch January 10, 2025 15:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants