Subscribers: Add subscribers-dataviews flag and component #97946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~351 bytes added 📈 [gzipped]) Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~38319 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1892 bytes removed 📉 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
One thing we will need to keep an eye on is the Jetpack cloud as well. I assume we want this section to be the same in Jetpack cloud? 
|
@arcangelini Yes, thanks for the reminder! The same but with Jetpack Cloud styles and Jetpack support links. I'll open an issue, but let me know if we should fix anything in this initial merge. |
allilevine
force-pushed
the
add/subscribers-dataviews
branch
2 times, most recently
from
d5f6afc to
389e785
Compare
allilevine
commented
Jan 10, 2025
| setSortTerm, | ||
| } = useSubscribersPage(); | ||
|
|
||
| const isSimple = useSelector( isSimpleSite ); |
There was a problem hiding this comment.
I'm preserving this empty view logic, but we could refactor or replace it.
allilevine
commented
Jan 10, 2025
| onGiftSubscription={ onGiftSubscription } | ||
| onClickUnsubscribe={ onClickUnsubscribe } | ||
| /> | ||
| { isEnabled( 'subscribers-dataviews' ) ? ( |
There was a problem hiding this comment.
I'm showing the new DataViews component when the flag is enabled. I repurposed a lot from the existing SubscriberListContainer component.
matticbot
added
the
[Status] Needs Review
allilevine
force-pushed
the
add/subscribers-dataviews
branch
from
389e785 to
05c3240
Compare
allilevine
commented
Jan 13, 2025
| import './style.scss'; | ||
|
|
||
| const SubscriptionTypeCell = ( { subscriber }: { subscriber: Subscriber } ) => { | ||
| const plans = useSubscriptionPlans( subscriber ); |
There was a problem hiding this comment.
I found that we're not returning plans data from the endpoint used here. So this is how it works in the individual subscriber page, but it's not actually working yet.
arcangelini
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Seems like a good start. Since this is just the foundation that is going to be behind a flag I say we ship. I tested for regressions and didn't run into any issue. There are a few things that need to be fixed but they are all covered in other issues (as far as I saw). 🚀 🚀
arcangelini
added
[Status] Ready to Merge
Newsletters
and removed
[Status] Needs Review
matticbot
added
the
[Status] Needs Review
arcangelini
added
the
[Feature] Subscriptions
github-actions
bot
removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Automattic/loop/issues/291
Proposed Changes
subscribers-dataviews.Why are these changes being made?
Testing Instructions
/subscribers/{ site id }?flags=subscribers-dataviewsNote: I tested with paid subscribers and we're not currently returning plans data from the endpoint used here.
Pre-merge Checklist