Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Remove line in tags page sidebar #97412

Closed
wants to merge 12 commits into from
Closed

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented Dec 12, 2024

Fixes https://github.com/Automattic/loop/issues/272

Before After
Screenshot 2024-12-12 at 14 43 58 Screenshot 2024-12-12 at 14 44 07

Proposed Changes

  • Removes style that causes line to appear in tags page sidebar

Why are these changes being made?

  • Tidy UI

Testing Instructions

  • Confirm line is no longer visible on tags page, i.e. /tag/gadgets

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@eoigal eoigal requested a review from a team as a code owner December 12, 2024 14:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 12, 2024
@eoigal eoigal changed the title Fix/tags page styles Reader: Remove line in tags page sidebar Dec 12, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/tags-page-styles on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 12, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~97555 bytes added 📈 [gzipped])

name                   parsed_size            gzip_size
entry-stepper            -861157 B  (-37.7%)  -193503 B  (-32.0%)
entry-login               +15749 B   (+0.8%)   +10691 B   (+1.8%)
entry-main                +14249 B   (+0.7%)    +9758 B   (+1.7%)
entry-domains-landing      +6412 B   (+0.9%)    +1925 B   (+0.9%)
entry-browsehappy          +6286 B   (+3.0%)    +1583 B   (+2.5%)
entry-subscriptions        +5596 B   (+0.3%)    +2433 B   (+0.5%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~282395 bytes added 📈 [gzipped])

name                                parsed_size             gzip_size
link-in-bio-tld-flow                  +333368 B   (+18.5%)  +104004 B   (+19.7%)
update-design-flow                    +302920 B   (+25.0%)   +86891 B   (+25.4%)
write-flow                            +287333 B   (+37.4%)   +90572 B   (+38.2%)
build-flow                            +287333 B   (+37.4%)   +90587 B   (+38.2%)
import-hosted-site-flow               +261926 B   (+31.5%)   +83102 B   (+33.4%)
copy-site-flow                        +257114 B   (+38.6%)   +82853 B   (+40.5%)
transferring-hosted-site-flow         +167311 B  (+163.3%)   +53891 B  (+157.5%)
entrepreneur-flow                     +165072 B  (+133.8%)   +46718 B  (+168.0%)
plugin-bundle-flow                    +164882 B   (+86.2%)   +52826 B   (+81.0%)
newsletter-post-setup-flow            +160920 B  (+137.4%)   +52338 B  (+131.3%)
link-in-bio-post-setup-flow           +160920 B  (+137.7%)   +52338 B  (+131.7%)
domain-user-transfer-flow             +134014 B   (+57.8%)   +42614 B   (+91.0%)
assembler-first-flow                  +132182 B  (+122.4%)   +35749 B  (+172.9%)
readymade-template-flow               +132013 B   (+94.1%)   +35063 B  (+113.0%)
site-setup-wg                          +46100 B   (+39.7%)    +7835 B   (+32.1%)
site-setup-flow                        +46100 B   (+40.2%)    +7835 B   (+33.1%)
ai-assembler-flow                      +43992 B   (+51.5%)    +7511 B   (+50.1%)
home                                   +42427 B    (+2.5%)   +12855 B    (+2.7%)
site-migration-flow                    +41062 B   (+46.7%)    +6861 B   (+43.0%)
hosted-site-migration-flow             +41062 B   (+46.4%)    +6861 B   (+42.3%)
with-theme-assembler-flow              +34328 B   (+45.6%)    +4367 B   (+37.3%)
import-flow                            +32739 B   (+48.3%)    +3994 B   (+40.0%)
migration-flow                         +31463 B   (+39.2%)    +3790 B   (+26.3%)
migration-signup                       +29615 B   (+47.0%)    +3197 B   (+38.4%)
onboarding-flow                        +25322 B   (+34.0%)    +1255 B   (+10.9%)
tailored-ecommerce-flow                +24104 B   (+39.4%)     +977 B   (+13.4%)
update-options-flow                    +22994 B   (+40.1%)     +849 B   (+13.6%)
trial-wooexpress-flow                  +22994 B   (+38.0%)     +865 B   (+11.5%)
free-post-setup-flow                   +22994 B   (+40.4%)     +831 B   (+13.5%)
design-first-flow                      +14499 B   (+56.3%)    +3351 B   (+55.8%)
start-writing-flow                     +14283 B   (+56.9%)    +3340 B   (+56.5%)
hundred-year-plan                      +13094 B   (+35.5%)    +3544 B   (+32.4%)
newsletter-flow                        +12613 B   (+60.3%)    +3288 B   (+59.1%)
hundred-year-domain                    +12006 B   (+23.7%)    +3576 B   (+23.6%)
signup                                  +7397 B    (+2.6%)    -2255 B    (-3.3%)
plans                                   -7204 B    (-0.5%)    -4603 B    (-1.1%)
jetpack-app                             -7029 B    (-1.7%)    -3431 B    (-2.6%)
jetpack-cloud-pricing                   -6914 B    (-0.9%)    -2701 B    (-1.2%)
staging-site                            -6863 B    (-0.4%)    -3315 B    (-0.8%)
sites-dashboard                         -6851 B    (-0.6%)    -2502 B    (-0.7%)
site-performance                        -6851 B    (-0.4%)    -2508 B    (-0.6%)
site-monitoring                         -6851 B    (-0.5%)    -2525 B    (-0.6%)
site-logs                               -6851 B    (-0.5%)    -2525 B    (-0.6%)
github-deployments                      -6775 B    (-0.5%)    -2502 B    (-0.6%)
pages                                   -6773 B    (-1.4%)    -2356 B    (-1.6%)
hosting-features                        -6752 B    (-0.5%)    -2432 B    (-0.7%)
site-marketing                          -6743 B    (-0.4%)    -2483 B    (-0.6%)
site-overview                           -6678 B    (-0.4%)    -2160 B    (-0.5%)
site-tools                              -6667 B    (-0.4%)    -2514 B    (-0.5%)
hosting                                 -6667 B    (-0.4%)    -2896 B    (-0.6%)
checkout                                -6665 B    (-0.4%)    -3144 B    (-0.6%)
jetpack-connect                         -6625 B    (-0.6%)    -1501 B    (-0.4%)
site-settings                           -6601 B    (-0.4%)    -2564 B    (-0.6%)
plugins                                 -6565 B    (-0.2%)    -3328 B    (-0.4%)
new-hosted-site-flow                    +1942 B   (+20.3%)     +103 B    (+3.6%)
connect-domain                          +1851 B    (+7.1%)     +243 B    (+3.4%)
reblogging-flow                         +1435 B   (+24.1%)      +70 B    (+3.8%)
new-hosted-site-flow-user-included      +1196 B   (+18.8%)      +62 B    (+3.0%)
google-transfer                         +1007 B   (+23.9%)      +78 B    (+5.7%)
domain-transfer                         +1007 B   (+25.5%)      +77 B    (+5.9%)
jetpack-cloud-plugin-management          +540 B    (+0.0%)     -276 B    (-0.0%)
jetpack-cloud-agency-sites-v2            -406 B    (-0.0%)     -581 B    (-0.1%)
migrate                                  -279 B    (-0.1%)     -386 B    (-0.4%)
a8c-for-agencies-team                    -279 B    (-0.0%)      +28 B    (+0.0%)
gutenberg-editor                         -265 B    (-0.0%)     -785 B    (-0.4%)
settings-jetpack                         -263 B    (-0.0%)     -305 B    (-0.2%)
jetpack-search                           -263 B    (-0.0%)     -652 B    (-0.4%)
patterns                                 -240 B    (-0.0%)     -730 B    (-0.1%)
people                                   +233 B    (+0.0%)     +459 B    (+0.2%)
activity                                 -215 B    (-0.0%)     -858 B    (-0.4%)
settings-writing                         +203 B    (+0.0%)      +39 B    (+0.0%)
customize                                -199 B    (-0.1%)     -502 B    (-0.5%)
preview                                  -191 B    (-0.1%)      -38 B    (-0.0%)
theme                                    -190 B    (-0.0%)     -239 B    (-0.1%)
site-profiler                            -186 B    (-0.1%)      -22 B    (-0.0%)
jetpack-cloud-settings                   -180 B    (-0.0%)    +1014 B    (+0.5%)
scan                                     -177 B    (-0.0%)    -1254 B    (-0.5%)
domains                                  -171 B    (-0.0%)     -950 B    (-0.2%)
themes                                   -168 B    (-0.0%)     +464 B    (+0.2%)
marketplace                              +159 B    (+0.0%)      -36 B    (-0.0%)
import                                   -147 B    (-0.0%)    -1210 B    (-0.5%)
subscribers                              +146 B    (+0.0%)     +593 B    (+0.3%)
settings                                 +141 B    (+0.0%)     +337 B    (+0.1%)
a8c-for-agencies-sites                   -134 B    (-0.0%)      +43 B    (+0.0%)
woocommerce                              +133 B    (+0.0%)      +27 B    (+0.0%)
settings-podcast                         +128 B    (+0.0%)       +6 B    (+0.0%)
marketing                                +128 B    (+0.0%)       +8 B    (+0.0%)
settings-performance                     +124 B    (+0.0%)      +16 B    (+0.0%)
promote-post-i2                          +113 B    (+0.0%)    +1038 B    (+0.4%)
jetpack-cloud-partner-portal             -113 B    (-0.0%)      -95 B    (-0.0%)
backup                                   -110 B    (-0.0%)     -456 B    (-0.1%)
a8c-for-agencies-partner-directory       -109 B    (-0.0%)      -21 B    (-0.0%)
stats                                     +98 B    (+0.0%)     -469 B    (-0.1%)
purchase-product                          -96 B    (-0.1%)      +21 B    (+0.0%)
comments                                  -88 B    (-0.0%)       -1 B    (-0.0%)
woocommerce-installation                  -87 B    (-0.0%)     -211 B    (-0.2%)
site-blocks                               -83 B    (-0.0%)       -7 B    (-0.0%)
performance-profiler                      -83 B    (-0.0%)      -22 B    (-0.0%)
notification-settings                     -83 B    (-0.0%)     +485 B    (+0.2%)
media                                     -83 B    (-0.0%)       -8 B    (-0.0%)
me                                        -83 B    (-0.0%)       -6 B    (-0.0%)
jetpack-social                            -83 B    (-0.0%)       -9 B    (-0.0%)
jetpack-cloud-overview                    -83 B    (-0.0%)      -18 B    (-0.0%)
jetpack-cloud-features-comparison         -83 B    (-0.0%)      -63 B    (-0.0%)
jetpack-cloud                             -83 B    (-0.0%)      -15 B    (-0.0%)
help                                      -83 B    (-0.0%)       -6 B    (-0.0%)
google-my-business                        -83 B    (-0.0%)       -9 B    (-0.0%)
export                                    -83 B    (-0.0%)       -9 B    (-0.0%)
email                                     -83 B    (-0.0%)      +69 B    (+0.0%)
concierge                                 -83 B    (-0.0%)       -9 B    (-0.0%)
add-ons                                   -83 B    (-0.0%)       -9 B    (-0.0%)
account-close                             -83 B    (-0.0%)       -6 B    (-0.0%)
a8c-for-agencies-referrals                -83 B    (-0.0%)     +196 B    (+0.1%)
a8c-for-agencies-purchases                -83 B    (-0.0%)      -21 B    (-0.0%)
a8c-for-agencies-overview                 -83 B    (-0.0%)     +172 B    (+0.1%)
a8c-for-agencies-migrations               -83 B    (-0.0%)     +196 B    (+0.1%)
a8c-for-agencies-marketplace              -83 B    (-0.0%)      -22 B    (-0.0%)
a8c-for-agencies-landing                  -83 B    (-0.1%)      -28 B    (-0.1%)
a8c-for-agencies                          -83 B    (-0.1%)      -22 B    (-0.1%)
devdocs                                   +81 B    (+0.0%)      +13 B    (+0.0%)
earn                                      -78 B    (-0.0%)     -649 B    (-0.3%)
settings-newsletter                       +71 B    (+0.0%)     -624 B    (-0.4%)
settings-security                         +41 B    (+0.0%)      +78 B    (+0.1%)
reader                                    -40 B    (-0.0%)       +3 B    (+0.0%)
site-purchases                            -30 B    (-0.0%)     -726 B    (-0.2%)
purchases                                 -30 B    (-0.0%)     -713 B    (-0.1%)
a8c-for-agencies-settings                 +30 B    (+0.0%)     -415 B    (-0.7%)
a8c-for-agencies-plugins                  +30 B    (+0.0%)     -415 B    (-0.8%)
a8c-for-agencies-agency-tier              +30 B    (+0.0%)     -421 B    (-0.6%)
settings-reading                          +20 B    (+0.0%)       +7 B    (+0.0%)
settings-discussion                       +20 B    (+0.0%)       +7 B    (+0.0%)
privacy                                   +20 B    (+0.0%)       +9 B    (+0.0%)
developer                                 +20 B    (+0.0%)       +9 B    (+0.0%)
account                                   +20 B    (+0.0%)       +6 B    (+0.0%)
posts-custom                              -11 B    (-0.0%)     -286 B    (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~210278 bytes added 📈 [gzipped])

name                                                                              parsed_size             gzip_size
async-load-calypso-my-sites-checkout-modal                                          +277760 B   (+22.9%)   +91071 B   (+26.6%)
async-load-automattic-help-center                                                   +210168 B   (+32.5%)   +66959 B   (+34.1%)
async-load-signup-steps-theme-selection                                             +115605 B   (+60.2%)   +37581 B   (+65.0%)
async-load-signup-steps-clone-point                                                  +96682 B   (+55.7%)   +30576 B   (+69.1%)
async-load-signup-steps-site-picker                                                  +94378 B   (+63.7%)   +30993 B   (+67.2%)
async-load-signup-steps-difm-site-picker                                             +94378 B   (+63.8%)   +31026 B   (+67.1%)
async-load-signup-steps-domains                                                      +93989 B   (+17.0%)   +30654 B   (+18.6%)
async-load-signup-steps-website-content                                              +84387 B   (+73.9%)   +26787 B   (+69.9%)
async-load-signup-steps-courses                                                      +80275 B  (+238.2%)   +25449 B  (+225.5%)
async-load-signup-steps-website-content-section-types                                +60918 B   (+85.2%)   +19439 B   (+84.4%)
async-load-calypso-blocks-jitm                                                       +59473 B  (+421.0%)   +18940 B  (+422.3%)
async-load-signup-steps-user                                                         +57072 B   (+34.1%)   +20440 B   (+42.6%)
async-load-signup-steps-page-picker                                                  +41219 B   (+10.9%)   +13249 B   (+11.2%)
async-load-signup-steps-p2-complete-profile                                          +40806 B   (+38.0%)   +13930 B   (+41.6%)
async-load-signup-steps-design-picker                                                +26014 B   (+49.1%)    +8192 B   (+46.8%)
async-load-signup-steps-woocommerce-install-step-business-info                       +25443 B   (+28.7%)    +8040 B   (+28.2%)
async-load-signup-steps-woocommerce-install-step-store-address                       +25353 B   (+38.1%)    +7950 B   (+36.0%)
async-load-signup-steps-creds-permission                                             +23275 B   (+44.9%)    +6760 B   (+38.5%)
async-load-signup-steps-woocommerce-install-transfer                                 +23210 B   (+72.3%)    +7349 B   (+70.1%)
async-load-signup-steps-woocommerce-install-confirm                                  +23028 B   (+41.7%)    +7365 B   (+41.1%)
async-load-signup-steps-store-features                                               +22896 B   (+51.9%)    +7154 B   (+52.0%)
async-load-signup-steps-p2-join-workspace                                            +22823 B   (+73.2%)    +7255 B   (+71.2%)
async-load-signup-steps-hosting-decider                                              +22814 B  (+101.3%)    +7275 B   (+94.1%)
async-load-signup-steps-p2-details                                                   +22695 B   (+90.2%)    +7271 B   (+85.7%)
async-load-signup-steps-site                                                         +22629 B   (+52.2%)    +7231 B   (+54.5%)
async-load-signup-steps-p2-site                                                      +22629 B   (+43.0%)    +7223 B   (+45.6%)
async-load-signup-steps-rewind-form-creds                                            +21593 B   (+30.7%)    +6293 B   (+27.5%)
async-load-signup-steps-creds-confirm                                                +21593 B   (+41.6%)    +6276 B   (+35.8%)
async-load-signup-steps-clone-credentials                                            +21593 B   (+29.2%)    +6288 B   (+26.5%)
async-load-signup-steps-new-or-existing-site                                         +21409 B   (+46.4%)    +6657 B   (+43.9%)
async-load-signup-steps-emails                                                       +21279 B   (+34.1%)    +6613 B   (+32.6%)
async-load-signup-steps-intent                                                       +21026 B   (+53.0%)    +6574 B   (+52.5%)
async-load-signup-steps-initial-intent                                               +20942 B   (+26.3%)    +6705 B   (+25.7%)
async-load-signup-steps-test-step                                                    +20880 B   (+97.5%)    +6520 B   (+90.8%)
async-load-signup-steps-starting-point                                               +20880 B   (+56.8%)    +6520 B   (+56.2%)
async-load-signup-steps-social-profiles                                              +20880 B   (+75.1%)    +6520 B   (+71.8%)
async-load-signup-steps-site-or-domain                                               +20880 B   (+50.8%)    +6520 B   (+51.7%)
async-load-signup-steps-site-options                                                 +20880 B   (+49.0%)    +6520 B   (+49.2%)
async-load-signup-steps-rewind-were-backing                                          +20880 B   (+90.9%)    +6520 B   (+84.4%)
async-load-signup-steps-reader-landing                                               +20880 B   (+81.1%)    +6520 B   (+78.6%)
async-load-signup-steps-p2-confirm-email                                             +20880 B   (+77.2%)    +6520 B   (+71.9%)
async-load-signup-steps-clone-start                                                  +20880 B   (+73.6%)    +6520 B   (+69.7%)
async-load-signup-steps-clone-destination                                            +20880 B   (+62.7%)    +6520 B   (+62.7%)
async-load-signup-steps-clone-cloning                                                +20880 B   (+74.8%)    +6520 B   (+71.1%)
async-load-calypso-signup-step-wrapper                                               +20880 B  (+133.7%)    +6520 B  (+124.5%)
async-load-signup-steps-clone-ready                                                  +20700 B   (+37.7%)    +6238 B   (+36.0%)
async-load-signup-steps-woocommerce-install                                          +20341 B  (+679.8%)    +6335 B  (+596.0%)
async-load-calypso-blocks-jitm-templates-modal                                       +20341 B   (+77.9%)    +6335 B   (+69.5%)
async-load-automattic-onboarding-src-step-container                                  +20341 B  (+209.8%)    +6335 B  (+195.2%)
async-load-purchase-modal-wrapper                                                    +18591 B    (+4.9%)    +6573 B    (+5.6%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...     +18395 B    (+5.1%)    +5932 B    (+5.3%)
async-load-calypso-blocks-cookie-banner                                              +15836 B      (new)    +5327 B      (new)
async-load-signup-steps-plans-theme-preselected                                      +11731 B    (+3.0%)    +2681 B    (+2.1%)
async-load-signup-steps-plans                                                        +11731 B    (+3.0%)    +2681 B    (+2.1%)
async-load-calypso-blocks-editor-checkout-modal                                       -6831 B    (-0.6%)    -2771 B    (-0.8%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                               +5155 B   (+11.1%)    +1931 B   (+11.7%)
async-load-calypso-blocks-jitm-templates-notice                                       +5155 B   (+11.0%)    +1930 B   (+11.6%)
async-load-calypso-blocks-jitm-templates-default                                      +5155 B   (+11.0%)    +1933 B   (+11.7%)
async-load-calypso-components-global-notices                                          +2911 B   (+60.3%)    +1072 B   (+63.4%)
async-load-signup-steps-woocommerce-install-hooks-use-site-settings                   +2690 B   (+65.1%)     +814 B   (+50.7%)
async-load-automattic-search                                                          +2685 B    (+8.9%)     +928 B    (+8.9%)
async-load-site-build-showcase                                                        +2231 B   (+92.3%)     +906 B   (+82.7%)
async-load-signup-steps-woocommerce-install-components-support-card                   +1943 B  (+145.7%)     +787 B  (+108.1%)
async-load-automattic-design-preview                                                  +1888 B    (+0.1%)     -363 B    (-0.1%)
async-load-calypso-state-lib-automated-transfer-middleware                             +996 B    (+4.9%)     +942 B   (+15.4%)
async-load-calypso-blocks-reader-full-post                                             +710 B    (+1.9%)     +173 B    (+1.6%)
async-load-calypso-components-web-preview-component                                    +486 B    (+0.1%)     -460 B    (-0.3%)
async-load-publish                                                                     +246 B    (+2.6%)      +41 B    (+1.2%)
async-load-calypso-blocks-support-article-dialog-dialog                                -236 B    (-0.3%)     -549 B    (-1.9%)
async-load-design-blocks                                                               +214 B    (+0.0%)     +718 B    (+0.1%)
async-load-calypso-my-sites-current-site-notice                                        +168 B    (+0.3%)       +6 B    (+0.0%)
async-load-calypso-my-sites-stats-summary                                              +151 B    (+0.3%)       +9 B    (+0.1%)
async-load-calypso-blocks-product-purchase-features-list                               -116 B    (-0.2%)     -363 B    (-2.9%)
async-load-calypso-layout-masterbar-drafts-popover                                     +113 B    (+0.4%)     +619 B    (+6.4%)
async-load-calypso-reader-sidebar                                                      +108 B    (+0.1%)       +0 B
async-load-calypso-my-sites-stats-stats-post-detail                                    -108 B    (-0.3%)      -33 B    (-0.3%)
async-load-calypso-my-sites-site-settings-seo-settings-form                            -108 B    (-0.0%)      -34 B    (-0.0%)
async-load-calypso-blocks-support-article-dialog                                       -108 B    (-5.6%)      -55 B    (-6.3%)
async-load-calypso-lib-store-sandbox-helper                                            +103 B    (+0.3%)      +16 B    (+0.2%)
async-load-calypso-components-sites-popover                                             -83 B    (-0.1%)       -9 B    (-0.0%)
async-load-calypso-components-jetpack-portal-nav                                        -83 B    (-0.2%)      -12 B    (-0.1%)
async-load-design-wordpress-components-gallery                                          +65 B    (+0.0%)       -3 B    (-0.0%)
async-load-calypso-my-sites-stats-comment-follows                                       +43 B    (+0.2%)       +9 B    (+0.1%)
async-load-comment-block-editor                                                         -41 B    (-0.0%)     -702 B    (-0.1%)
async-load-automattic-global-styles-src-components-global-styles-variations             -41 B    (-0.0%)     -702 B    (-0.1%)
async-load-design-playground                                                            +20 B    (+0.0%)       +9 B    (+0.0%)
async-load-store-app-store-stats-listview                                               +13 B    (+0.0%)      -16 B    (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

mmtr and others added 8 commits December 12, 2024 14:56
Some back-and-forth to try and unflaky this test... Mix of race condition abort/goto and not being able to hover->click.

---------

Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Kosta <heavyweight@users.noreply.github.com>
* accept both remote and base64 urls and produce a well formed request for each

* move first logo generation prompt to backend

* use new flux request if a style is used as URL hash

* add image types and constants, add featuresControl to state

* remove style setting from URL hash

* modify hook functions to accept style for the request

* implement styles dropdown on logo generator prompt

* wee css fixes: spacing actions and make button logo (SVG) same color as button
@eoigal eoigal requested review from a team as code owners December 12, 2024 14:56
@eoigal
Copy link
Contributor Author

eoigal commented Dec 12, 2024

Closing this mess of a PR!

@eoigal eoigal closed this Dec 12, 2024
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants