Cleanup: deprecate the availability checks of the storage add-on

[southp]

Proposed Changes

Now that the storage add-ons have become part of our standard offers, this PR removes the availability checks of the storage add-on, particularly within the use-add-on hook:

• Remove all the storage add-on feature flag.
• Remove enableStorageAddOn parameter since it's not in used.
• Remove the function that checks if the storage add-on is enabled.

Why are these changes being made?

Since the storage add-ons are available by default now and there is no need for hiding them conditionally at the moment, cleaning the code up will ease the maintenance burden.

Testing Instructions

• Confirm that the storage add-ons related UX works as expected in /add-ons.
• Confirm that the storage add-on dropdown works as expected in /plans.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127348

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127348&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127348&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• notifications
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug cleanup/remove-storage-addon-config-flag on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~207 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
update-design-flow         -185 B  (-0.0%)      -76 B  (-0.0%)
site-overview              -185 B  (-0.0%)      -65 B  (-0.0%)
plugins                    -185 B  (-0.0%)      -76 B  (-0.0%)
plans                      -185 B  (-0.0%)      -76 B  (-0.0%)
link-in-bio-tld-flow       -185 B  (-0.0%)      -76 B  (-0.0%)
jetpack-app                -185 B  (-0.0%)      -76 B  (-0.1%)
hosting                    -185 B  (-0.0%)      -65 B  (-0.0%)
add-ons                    -185 B  (-0.1%)      -66 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~76 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected       -185 B  (-0.0%)      -76 B  (-0.1%)
async-load-signup-steps-plans                         -185 B  (-0.0%)      -76 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.