Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AI to Complete feature copy #97360

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

CodeyGuyDylan
Copy link
Contributor

Proposed Changes

  • Add AI to Complete feature copy

Why are these changes being made?

We are adding Jetpack AI to the Complete bundle: pbNhbs-cbd-p2

Testing Instructions

  1. Open the Calypso Blue live link and go to /checkout/jetpack/jetpack_complete
  2. Ensure you see AI Assistant as a feature to complete
    Screenshot 2024-12-11 at 12 52 07 PM
  3. Open the Calypso Green live link and go to /pricing#jetpack_complete
  4. Ensure you see AI as a feature
    Screenshot 2024-12-11 at 12 53 28 PM
  5. Now go to /features/comparison
  6. Ensure you see High request capacity for AI under the Complete plan
    Screenshot 2024-12-11 at 12 54 35 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@CodeyGuyDylan CodeyGuyDylan requested a review from a team as a code owner December 11, 2024 19:54
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 11, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/ai-to-complete-feature-copy on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~11 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +18 B  (+0.0%)      +11 B  (+0.0%)
entry-main           +18 B  (+0.0%)      +11 B  (+0.0%)
entry-login          +18 B  (+0.0%)      +11 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~258 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
jetpack-cloud-features-comparison       +151 B  (+0.0%)      +91 B  (+0.0%)
scan                                    +133 B  (+0.0%)      +79 B  (+0.0%)
plans                                   +133 B  (+0.0%)      +76 B  (+0.0%)
jetpack-social                          +133 B  (+0.0%)      +79 B  (+0.0%)
jetpack-search                          +133 B  (+0.0%)      +79 B  (+0.0%)
jetpack-connect                         +133 B  (+0.0%)      +76 B  (+0.0%)
jetpack-cloud-pricing                   +133 B  (+0.0%)      +76 B  (+0.0%)
jetpack-cloud-partner-portal            +133 B  (+0.0%)      +79 B  (+0.0%)
jetpack-cloud-manage-pricing            +133 B  (+0.0%)      +76 B  (+0.1%)
jetpack-cloud-agency-sites-v2           +133 B  (+0.0%)      +79 B  (+0.0%)
backup                                  +133 B  (+0.0%)      +79 B  (+0.0%)
a8c-for-agencies-sites                  +133 B  (+0.0%)      +79 B  (+0.0%)
a8c-for-agencies-marketplace            +133 B  (+0.0%)      +79 B  (+0.0%)
checkout                                 +18 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~9 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     +18 B  (+0.0%)       +9 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       +18 B  (+0.0%)       +9 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +18 B  (+0.0%)       +9 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                              +18 B  (+0.0%)       +9 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                                         +18 B  (+0.0%)       +9 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@robertsreberski robertsreberski merged commit 660b6bc into trunk Dec 30, 2024
14 of 15 checks passed
@robertsreberski robertsreberski deleted the add/ai-to-complete-feature-copy branch December 30, 2024 10:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 30, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 30, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17084991

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @CodeyGuyDylan for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jan 6, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants