-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain management: Match component design for Google mailbox usecase #97348
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~267 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
ae2bf4a
to
402ac97
Compare
b2f62cd
to
13cadbc
Compare
ec47f67
to
6eb9cb4
Compare
client/my-sites/email/email-management/home/email-plan-mailboxes-list.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! The code looks good and works as expected, I also didn't spot any regression in the old UIs.
Closes #96823
Proposed Changes
EmailPlanMailboxesList
matching Figma design proposalsWhy are these changes being made?
Testing Instructions
/domains/manage?flags=calypso/all-domain-management
/domains/manage/all/email/{DOMAIN}/{DOMAIN}
NOTE: This PR only handles UI matching FIGMA design; the UX and the flow with redirections will be handled in the separate PRs.
Pre-merge Checklist