Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management: Match component design for Google mailbox usecase #97348

Merged
merged 17 commits into from
Dec 16, 2024

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Dec 11, 2024

Closes #96823

Proposed Changes

  • Update EmailPlanMailboxesList matching Figma design proposals
    • Google configuring state: ePfz53j71KKDLWtuSm567A-fi-4951_11732
    • Finish setup state: ePfz53j71KKDLWtuSm567A-fi-4953_14100
  • Adapt email-related components to support different states

Why are these changes being made?

  • All Domain Management

Testing Instructions

  • Go to: /domains/manage?flags=calypso/all-domain-management
  • Select or create your domain
  • Choose the Email tab
  • Select the "Google Workspace" option
  • Purchase it with you credits
  • Manually go to /domains/manage/all/email/{DOMAIN}/{DOMAIN}
  • Check transition screens when google is configuring the mailbox
  • At the end, check the regular flow for regression

NOTE: This PR only handles UI matching FIGMA design; the UX and the flow with redirections will be handled in the separate PRs.

Screenshot 2024-12-13 at 19 24 14 Screenshot 2024-12-13 at 19 35 29 Screenshot 2024-12-13 at 19 36 40

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii self-assigned this Dec 11, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 11, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~267 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
email        +1038 B  (+0.1%)     +267 B  (+0.1%)
domains      +1038 B  (+0.0%)     +267 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Dec 11, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domains-management-email-4 on your sandbox.

@bogiii bogiii changed the base branch from trunk to update/domains-management-email-3 December 12, 2024 09:37
@bogiii bogiii force-pushed the update/domains-management-email-3 branch from ae2bf4a to 402ac97 Compare December 12, 2024 09:50
@bogiii bogiii force-pushed the update/domains-management-email-4 branch from b2f62cd to 13cadbc Compare December 12, 2024 09:54
@bogiii bogiii requested a review from a team December 13, 2024 09:38
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 13, 2024
@bogiii bogiii changed the title Update/domains management email 4 Domain management: Match component design for Google mailbox usecase Dec 13, 2024
Base automatically changed from update/domains-management-email-3 to trunk December 13, 2024 15:51
@bogiii bogiii force-pushed the update/domains-management-email-4 branch from ec47f67 to 6eb9cb4 Compare December 13, 2024 18:21
@bogiii bogiii marked this pull request as ready for review December 13, 2024 18:55
@bogiii bogiii requested a review from a team as a code owner December 13, 2024 18:55
@bogiii bogiii requested a review from phcp December 16, 2024 12:19
Copy link
Contributor

@phcp phcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The code looks good and works as expected, I also didn't spot any regression in the old UIs.

@bogiii bogiii merged commit 267b541 into trunk Dec 16, 2024
12 checks passed
@bogiii bogiii deleted the update/domains-management-email-4 branch December 16, 2024 15:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Emails page tab when users have Google mailboxes
3 participants