-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paid stats: add Stats reference on Personal checkout #97305
Conversation
…PAID` title/description under `stats/paid-wpcom-v3` feature flag
…TATS_COMMERCIAL` under `stats/paid-wpcom-v3` feature flag
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~93 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described 👍
Co-authored-by: Louis Laugesen <louis.laugesen@gmail.com>
Co-authored-by: Louis Laugesen <louis.laugesen@gmail.com>
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17057489 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @Initsogar for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Resolves https://github.com/Automattic/red-team/issues/305
We want to include Stats features on the checkout page while purchasing a WordPress.com Personal plan.
To achieve this, we need to replace the existing feature texts from
FEATURE_STATS_PAID
withFEATURE_STATS_COMMERCIAL
and add the new feature message forFEATURE_STATS_PAID
on the checkout page.To ensure a smooth transition, these changes are being made conditionally under the
stats/paid-wpcom-v3
feature flag to ensure everything works as expected.Note
Due to restrictions on how the features list is presented, I am merging both lines into a single line while we gather feedback from the design team. I believe it is safe to proceed with this PR and iterate if needed.
Proposed Changes
FEATURE_STATS_COMMERCIAL
feature details using the existingFEATURE_STATS_PAID
.FEATURE_STATS_PAID
title/description with the new texts under thestats/paid-wpcom-v3
feature flag.FEATURE_STATS_PAID
with conditional logic to useFEATURE_STATS_COMMERCIAL
under thestats/paid-wpcom-v3
feature flag in the Calypso plans list configuration.FEATURE_STATS_PAID
will continue working as usual and will switch toFEATURE_STATS_COMMERCIAL
when the feature flag is enabled.Why are these changes being made?
https://github.com/Automattic/red-team/issues/305
Testing Instructions
Validate Personal checkout has the new message under
stats/paid-wpcom-v3
flagUpgrade plan
onClicks
module.Stats beyond last 7 days
message in the features list (the feature flag is enabled by default in live branch environment).?flags=-stats/paid-wpcom-v3
to the checkout page.Validate Premium checkout is not affected
Upgrade plan
on the UTM or Devices module.In-depth site analytics dashboard.
in the features list, with and without thestats/paid-wpcom-v3
flag.Pre-merge Checklist