Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: improve tooltips consistency #97301

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Stats: improve tooltips consistency #97301

merged 1 commit into from
Dec 11, 2024

Conversation

myhro
Copy link
Contributor

@myhro myhro commented Dec 10, 2024

Part of Automattic/red-team#193.

Proposed Changes

Improve tooltips consistency in the Insights and Subscribers page.

Why are these changes being made?

This is part of the efforts started by Design (p1HpG7-unJ-p2) to increase consistency between different Stats tooltips.

Testing Instructions

  • Go to the Stats page of any website that has meaningful data.
    • I've used cicerosletters.wordpress.com in these tests: /stats/day/cicerosletters.wordpress.com
  • Check the tooltips by hovering over the different stats in the Insights and Subscribers tabs, as shown in the screenshots below.

Insights

Before After
image image

Subscribers

Before After
image image
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~25 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
earn        +52 B  (+0.0%)      +25 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~138 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-subscribers       +211 B  (+0.1%)      +90 B  (+0.2%)
async-load-calypso-my-sites-stats-pages-insights           +80 B  (+0.1%)      +32 B  (+0.2%)
async-load-calypso-my-sites-stats-wordads                  +52 B  (+0.2%)      +16 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@kangzj kangzj requested a review from a team December 11, 2024 03:27
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
@kangzj kangzj added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 11, 2024
Copy link
Contributor

@a8ck3n a8ck3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me. Thanks for the changes!

@myhro myhro merged commit 4823dde into trunk Dec 11, 2024
14 of 15 checks passed
@myhro myhro deleted the fix/stats-improve-tooltips branch December 11, 2024 10:53
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 11, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17058057

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @myhro for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 15, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants