-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: improve tooltips consistency #97301
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~25 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~138 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me. Thanks for the changes!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17058057 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @myhro for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Part of Automattic/red-team#193.
Proposed Changes
Improve tooltips consistency in the
Insights
andSubscribers
page.Why are these changes being made?
This is part of the efforts started by Design (p1HpG7-unJ-p2) to increase consistency between different Stats tooltips.
Testing Instructions
Stats
page of any website that has meaningful data.cicerosletters.wordpress.com
in these tests:/stats/day/cicerosletters.wordpress.com
Insights
andSubscribers
tabs, as shown in the screenshots below.Insights
Subscribers
Pre-merge Checklist