-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally update UI on DIFM vs. DIY step of migration flow #97257
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~82 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~42 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
4634d44
to
d186a87
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17057351 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @donnapep for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and thanks for the tests! 🥂
@fditrapani for a sneaky peeky of the new experimental UI for the DIY vs. DIFM page. |
Thanks for the ping! Looks great from the screenshots ❤️
No problem. I'm glad you did this, it's better to work within the system rather than creating one off inconsistencies. We can always adjust the copy later if it feels too long. |
Translation for this Pull Request has now been finished. |
Related to https://github.com/Automattic/dotcom-forge/issues/10025.
Proposed Changes
Updates the UI on the DIFM vs. DIY step of the migration flow. These changes are currently behind a feature flag and will be launched as part of a future experiment.
Testing Instructions
migration-flow/experiment
feature flag inconfig/development.json
.siteId
andsiteSlug
query params with appropriate values for a Business plan site).Pre-merge Checklist