Stepper: Fix navigation UI in Stepper

[alshakero]

Fixes: #97067

Proposed Changes

• This fixes the navigation buttons and the formatted header in Stepper and makes them consistent with /start.
• It cleans up the never used shouldStickyNavButtons property and the CSS that comes with it.

Why are these changes being made?

To bring consistency.

Testing Instructions

1. Using incognito, open two tabs one to /setup/onboarding and one to /start.
2. The user step should look 99% identical between the two. On desktop and on mobile.
3. Feel free to leave incognito mode.
4. The domain step should look 99% identical between the two. On desktop and on mobile.
5. The plans step should look 99% identical between the two. On desktop and on mobile.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127065

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127065&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127065&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~102 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                   +69 B  (+0.0%)     +109 B  (+0.0%)
entry-stepper                +52 B  (+0.0%)     +101 B  (+0.0%)
entry-subscriptions          -39 B  (-0.0%)      +61 B  (+0.0%)
entry-login                  -39 B  (-0.0%)      +62 B  (+0.0%)
entry-domains-landing        -39 B  (-0.0%)      +61 B  (+0.0%)
entry-browsehappy            -39 B  (-0.0%)      +61 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~23733 bytes removed 📉 [gzipped])

name                           parsed_size           gzip_size
copy-site-flow                     -1354 B  (-0.2%)     -586 B  (-0.3%)
plugin-bundle-flow                 -1345 B  (-0.7%)     -605 B  (-0.9%)
transferring-hosted-site-flow      -1328 B  (-1.3%)     -490 B  (-1.4%)
newsletter-post-setup-flow         -1328 B  (-1.1%)     -491 B  (-1.2%)
link-in-bio-post-setup-flow        -1328 B  (-1.1%)     -491 B  (-1.2%)
domain-user-transfer-flow          -1328 B  (-0.6%)     -595 B  (-1.3%)
import-hosted-site-flow            -1122 B  (-0.1%)    -1211 B  (-0.5%)
update-design-flow                 -1032 B  (-0.1%)     -543 B  (-0.2%)
entrepreneur-flow                  -1006 B  (-0.8%)     -456 B  (-1.6%)
with-theme-assembler-flow           +322 B  (+0.4%)      +41 B  (+0.3%)
update-options-flow                 +322 B  (+0.6%)      +37 B  (+0.6%)
trial-wooexpress-flow               +322 B  (+0.5%)      +34 B  (+0.4%)
tailored-ecommerce-flow             +322 B  (+0.5%)      +37 B  (+0.5%)
site-setup-wg                       +322 B  (+0.3%)      +35 B  (+0.1%)
site-setup-flow                     +322 B  (+0.3%)      +35 B  (+0.1%)
site-migration-flow                 +322 B  (+0.4%)      +36 B  (+0.2%)
readymade-template-flow             +322 B  (+0.2%)      +39 B  (+0.1%)
onboarding-flow                     +322 B  (+0.4%)      +34 B  (+0.3%)
migration-signup                    +322 B  (+0.5%)      +36 B  (+0.4%)
migration-flow                      +322 B  (+0.4%)      +36 B  (+0.2%)
import-flow                         +322 B  (+0.5%)      +41 B  (+0.4%)
hosted-site-migration-flow          +322 B  (+0.4%)      +36 B  (+0.2%)
free-post-setup-flow                +322 B  (+0.6%)      +38 B  (+0.6%)
assembler-first-flow                +322 B  (+0.3%)      +36 B  (+0.2%)
ai-assembler-flow                   +322 B  (+0.4%)      +39 B  (+0.3%)
link-in-bio-tld-flow                -210 B  (-0.0%)      -66 B  (-0.0%)
write-flow                          -184 B  (-0.0%)      -62 B  (-0.0%)
plans                               -184 B  (-0.0%)      -59 B  (-0.0%)
build-flow                          -184 B  (-0.0%)      -62 B  (-0.0%)
start-writing-flow                   -93 B  (-0.4%)       -7 B  (-0.1%)
design-first-flow                    -93 B  (-0.4%)       -9 B  (-0.1%)
import                               -89 B  (-0.0%)    +2064 B  (+0.9%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~992 bytes removed 📉 [gzipped])

name                                                 parsed_size            gzip_size
async-load-signup-steps-initial-intent                   -1328 B   (-1.6%)     -496 B   (-1.8%)
async-load-automattic-onboarding-src-step-container      -1328 B  (-12.0%)     -496 B  (-13.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[escapemanuele]

I see a big number of improvements!

Can you check this? It happens under 1080px

[alshakero]

Can you check this? It happens under 1080px

Fixed in b612729 (#97256)

[heavyweight]

Truly minor difference in the way the login button is aligned but I think stepper in correct here

Stepper	Start

[heavyweight]

However here I think we need to fix the header

Stepper	Start

[alshakero]

I cleaned up the CSS more and tested the user step, the domains step, and the plans step. On Mobile, Tablet, and Desktop.

[heavyweight]

LGTM

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/navigation-on-stepper on your sandbox.

[valterlorran]

I noticed that this changed the whole stepper design. I'm not sure if that was the right call. @fditrapani can you chime on this? I started reporting this here:
p1733858844922699-slack-C0Q664T29

[fditrapani]

Thanks for the ping @valterlorran. I have been following this work on the stepper. It does look like the spacing is different than before. I don't think it's a bad thing though. We'll just have to make some adjustments on the non-stepper screens before and after the stepper used in migrations to line everything up.

[alshakero]

Quoting my reply on Slack

Hi everyone! I tried to meticulously copy the spacing of /start into Stepper around StepContainers and FormattedHeaders. I was very careful but please do tell me if you see any mistakes.

[arthur791004]

This changed the navigation position on other steps under the stepper flow. Is it exptected 🤔

[p-jackson]

It removed some CSS which was needed to to have the goals step actions appear in the footer. My guess is it was assumed that the shouldStickyNavButtons prop was for controlling this, however in reality all the footers were sticky regardless of the prop.
I'm working on reinstating the sticky footer but with a prop that can disable it for the signup step.

[p-jackson]

Does this fix both issues @alshakero? #97503