Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip left alignment #97237

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Tooltip left alignment #97237

merged 2 commits into from
Dec 10, 2024

Conversation

j6ll
Copy link
Member

@j6ll j6ll commented Dec 9, 2024

Proposed Changes

  • Makes the tooltip text left aligned, request from Bart.
  • Remove today, it is often the case that it doesn't have enough data
Screenshot 2024-12-09 at 11 09 14

Screenshot 2024-12-09 at 16 06 28

Testing Instructions

Load a campaign using the calypso live link in the comments, go to view the campaign details

  • tooltip should have text left aligned
  • Today should not be an option for the chart date filters

Screenshot 2024-12-09 at 11 08 09

Screen.Recording.2024-12-09.at.16.07.56.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Dec 9, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~37 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
promote-post-i2       -129 B  (-0.0%)      -37 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug jamesgill23/left-align-tooltip on your sandbox.

@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 9, 2024
Copy link
Contributor

@timur987 timur987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j6ll , the code looks great and works as advertised 🏅

@timur987 timur987 merged commit bf8b834 into trunk Dec 10, 2024
18 of 20 checks passed
@timur987 timur987 deleted the jamesgill23/left-align-tooltip branch December 10, 2024 16:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants