Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlueSky to feature copy on pricing page and features in checkout #97138

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

CodeyGuyDylan
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan commented Dec 5, 2024

Proposed Changes

  • Add BlueSky to list of social networks Social can share to in feature copy

Why are these changes being made?

  • BlueSky is currently missing

Testing Instructions

  1. Using the Calypso Green live link, go to /pricing

  2. Open up the lightbox for Social and ensure "BlueSky" is listed
    Screenshot 2024-12-05 at 1 50 01 PM

  3. Next, using the Calypso Blue live link, go to /checkout/jetpack/jetpack_social_v1_yearly and ensure BlueSky is listed in the social sharing section

Screenshot 2024-12-05 at 1 50 34 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@CodeyGuyDylan CodeyGuyDylan requested a review from a team as a code owner December 5, 2024 20:34
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 5, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~47 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
checkout                                +110 B  (+0.0%)      +47 B  (+0.0%)
site-purchases                           +20 B  (+0.0%)       +8 B  (+0.0%)
site-overview                            +20 B  (+0.0%)       +8 B  (+0.0%)
settings-jetpack                         +20 B  (+0.0%)       +8 B  (+0.0%)
settings                                 +20 B  (+0.0%)       +8 B  (+0.0%)
scan                                     +20 B  (+0.0%)       +8 B  (+0.0%)
purchases                                +20 B  (+0.0%)       +8 B  (+0.0%)
purchase-product                         +20 B  (+0.0%)       +8 B  (+0.0%)
plans                                    +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-social                           +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-search                           +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-connect                          +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-settings                   +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-pricing                    +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-plugin-management          +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-partner-portal             +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-manage-pricing             +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-features-comparison        +20 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-agency-sites-v2            +20 B  (+0.0%)       +8 B  (+0.0%)
hosting                                  +20 B  (+0.0%)       +8 B  (+0.0%)
email                                    +20 B  (+0.0%)       +8 B  (+0.0%)
domains                                  +20 B  (+0.0%)       +8 B  (+0.0%)
backup                                   +20 B  (+0.0%)       +8 B  (+0.0%)
a8c-for-agencies-sites                   +20 B  (+0.0%)       +8 B  (+0.0%)
a8c-for-agencies-purchases               +20 B  (+0.0%)       +8 B  (+0.0%)
a8c-for-agencies-marketplace             +20 B  (+0.0%)       +8 B  (+0.0%)
a8c-for-agencies-client                  +20 B  (+0.0%)       +8 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~47 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal                                             +110 B  (+0.0%)      +47 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                                        +110 B  (+0.0%)      +47 B  (+0.0%)
async-load-signup-steps-page-picker                                                     +90 B  (+0.0%)      +39 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       +90 B  (+0.0%)      +39 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +90 B  (+0.0%)      +39 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/bluesky-to-social-sharing-feature-copy on your sandbox.

Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@CodeyGuyDylan CodeyGuyDylan merged commit 150e657 into trunk Dec 6, 2024
12 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the add/bluesky-to-social-sharing-feature-copy branch December 6, 2024 18:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 6, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17050568

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @CodeyGuyDylan for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 11, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants