Revert previous change on state

[ouikhuan]

Related to #96959

Proposed Changes

• Since expanded props is optional, we shouldn't do the comparison check between props and state here. This PR reverts the changes we made in Foldable card component.

Why are these changes being made?

• For components without expanded props, it'll gets unexpected behavior.

Testing Instructions

• Try to open pages with foldable components that's using dynamic data. You can do the following test to make sure this works as expected.
• Follow the instructions found here Google Photos Picker: Fix foldable card state issue #96959 (comment)
• Follow the instructions found here Domains: Fix domain "contact information" accordion #97093

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-eb87c9e585c36cc930f3156e0e3e7fb6b74c9926

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-eb87c9e585c36cc930f3156e0e3e7fb6b74c9926&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-eb87c9e585c36cc930f3156e0e3e7fb6b74c9926&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~191 bytes removed 📉 [gzipped])

name                               parsed_size           gzip_size
write-flow                               -36 B  (-0.0%)       -6 B  (-0.0%)
update-design-flow                       -36 B  (-0.0%)      -11 B  (-0.0%)
site-tools                               -36 B  (-0.0%)       -7 B  (-0.0%)
site-profiler                            -36 B  (-0.0%)       -6 B  (-0.0%)
site-performance                         -36 B  (-0.0%)       -6 B  (-0.0%)
site-marketing                           -36 B  (-0.0%)       -5 B  (-0.0%)
settings-writing                         -36 B  (-0.0%)       -5 B  (-0.0%)
settings-security                        -36 B  (-0.0%)       -7 B  (-0.0%)
security                                 -36 B  (-0.0%)       -3 B  (-0.0%)
scan                                     -36 B  (-0.0%)       -5 B  (-0.0%)
plugins                                  -36 B  (-0.0%)      -11 B  (-0.0%)
plans                                    -36 B  (-0.0%)      -11 B  (-0.0%)
performance-profiler                     -36 B  (-0.0%)       -6 B  (-0.0%)
media                                    -36 B  (-0.0%)       -6 B  (-0.0%)
marketing                                -36 B  (-0.0%)       -5 B  (-0.0%)
link-in-bio-tld-flow                     -36 B  (-0.0%)      -11 B  (-0.0%)
jetpack-social                           -36 B  (-0.0%)       -5 B  (-0.0%)
jetpack-search                           -36 B  (-0.0%)       -5 B  (-0.0%)
jetpack-connect                          -36 B  (-0.0%)       -6 B  (-0.0%)
jetpack-cloud-settings                   -36 B  (-0.0%)       -5 B  (-0.0%)
jetpack-cloud-pricing                    -36 B  (-0.0%)       -6 B  (-0.0%)
jetpack-cloud-plugin-management          -36 B  (-0.0%)       -6 B  (-0.0%)
jetpack-cloud-partner-portal             -36 B  (-0.0%)       -5 B  (-0.0%)
jetpack-cloud-overview                   -36 B  (-0.0%)       -8 B  (-0.0%)
jetpack-cloud-manage-pricing             -36 B  (-0.0%)       -6 B  (-0.0%)
jetpack-cloud-features-comparison        -36 B  (-0.0%)       -4 B  (-0.0%)
jetpack-cloud-agency-sites-v2            -36 B  (-0.0%)       -5 B  (-0.0%)
jetpack-app                              -36 B  (-0.0%)      -11 B  (-0.0%)
import                                   -36 B  (-0.0%)       -4 B  (-0.0%)
home                                     -36 B  (-0.0%)       -3 B  (-0.0%)
github-deployments                       -36 B  (-0.0%)       -7 B  (-0.0%)
export                                   -36 B  (-0.0%)       -7 B  (-0.0%)
earn                                     -36 B  (-0.0%)       -7 B  (-0.0%)
domains                                  -36 B  (-0.0%)       -5 B  (-0.0%)
copy-site-flow                           -36 B  (-0.0%)       -7 B  (-0.0%)
concierge                                -36 B  (-0.0%)       -7 B  (-0.0%)
comments                                 -36 B  (-0.0%)       -5 B  (-0.0%)
checkout                                 -36 B  (-0.0%)       -6 B  (-0.0%)
build-flow                               -36 B  (-0.0%)       -6 B  (-0.0%)
backup                                   -36 B  (-0.0%)       -5 B  (-0.0%)
activity                                 -36 B  (-0.0%)       -5 B  (-0.0%)
a8c-for-agencies-sites                   -36 B  (-0.0%)       -5 B  (-0.0%)
a8c-for-agencies-referrals               -36 B  (-0.0%)       -6 B  (-0.0%)
a8c-for-agencies-overview                -36 B  (-0.0%)       -8 B  (-0.0%)
a8c-for-agencies-migrations              -36 B  (-0.0%)       -6 B  (-0.0%)
a8c-for-agencies-marketplace             -36 B  (-0.0%)       -7 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~45 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected                                         -36 B  (-0.0%)      -11 B  (-0.0%)
async-load-signup-steps-plans                                                           -36 B  (-0.0%)      -11 B  (-0.0%)
async-load-signup-steps-page-picker                                                     -36 B  (-0.0%)       -6 B  (-0.0%)
async-load-signup-steps-domains                                                         -36 B  (-0.0%)       -7 B  (-0.0%)
async-load-signup-steps-clone-point                                                     -36 B  (-0.0%)       -7 B  (-0.0%)
async-load-purchase-modal-wrapper                                                       -36 B  (-0.0%)       -6 B  (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -36 B  (-0.0%)       -6 B  (-0.0%)
async-load-design-playground                                                            -36 B  (-0.0%)       -8 B  (-0.0%)
async-load-design-blocks                                                                -36 B  (-0.0%)       -6 B  (-0.0%)
async-load-design                                                                       -36 B  (-0.0%)       -8 B  (-0.0%)
async-load-calypso-post-editor-media-modal                                              -36 B  (-0.0%)       -6 B  (-0.0%)
async-load-calypso-post-editor-editor-media-modal                                       -36 B  (-0.0%)       -6 B  (-0.0%)
async-load-calypso-my-sites-checkout-modal                                              -36 B  (-0.0%)       -6 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal                                         -36 B  (-0.0%)       -6 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[bogiii]

👍

[epeicher]

I have tested in the Speed Test tool, and it works as expected.