Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goal centric filter groups in design picker #97113

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Add goal centric filter groups in design picker #97113

merged 2 commits into from
Dec 6, 2024

Conversation

madhusudhand
Copy link
Member

Related to https://github.com/Automattic/dotcom-forge/issues/10014

Proposed Changes

  • Adds filter groups Features and Subjects to the design picker
  • It fallbacks to old view when multi-selection is false
image image

Note:

Buttons aren't given any background as suggested in the mocks. It will be iterated in a followup PR.
image

Why are these changes being made?

  • To enhance design filtering experience

Testing Instructions

  • Disable the feature design-picker/goal-centric
  • It should show default view of filters with single selection.
  • Now enable design-picker/goal-centric
  • It should now show two filter groups Features and Subjects and user should be able to select unselect any of the categories.
  • Verify the UI in the small screens.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@madhusudhand madhusudhand requested a review from a team December 5, 2024 11:59
@madhusudhand madhusudhand self-assigned this Dec 5, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-126740
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-126740&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-126740&env=a8c-for-agencies

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

madhusudhand
madhusudhand commented Dec 5, 2024
View reviewed changes
packages/design-picker/src/components/unified-design-picker.tsx Outdated
@@ -207,34 +227,72 @@ const DesignPicker: React.FC< DesignPickerProps > = ( {
} ) => {
const hasCategories = !! Object.keys( categorization?.categories || {} ).length;
const filteredDesigns = useFilteredDesigns( designs, categorization );

// Pick design
const features = [ 'blog', 'magazine', 'portfolio', 'podcast', 'store' ];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not newsletter in the list of categories. I have used magazine instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only 2 recommended newsletter designs so the newsletter category is hidden. We have to add more designs to display it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ola is working on adding more themes to newsletter. It's fine if we only render 4 features in the meantime!

arthur791004
arthur791004 reviewed Dec 5, 2024
View reviewed changes
packages/design-picker/src/components/unified-design-picker.tsx Outdated

// Pick design
const features = [ 'blog', 'magazine', 'portfolio', 'podcast', 'store' ];
const [ featureCategories, setFeatureCategories ] = useState< Category[] >( [] );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simply use useMemo to get features and subjects 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion :) Fixed in d1ab480

@madhusudhand madhusudhand force-pushed the feature/goal-centric-filters branch from ae28198 to d1ab480 Compare December 6, 2024 06:41
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feature/goal-centric-filters on your sandbox.

arthur791004
arthur791004 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@madhusudhand madhusudhand merged commit 31ecffc into trunk Dec 6, 2024
11 checks passed
@madhusudhand madhusudhand deleted the feature/goal-centric-filters branch December 6, 2024 07:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 6, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17049293

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @madhusudhand for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 9, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taipeicoder taipeicoder taipeicoder left review comments

@arthur791004 arthur791004 arthur791004 approved these changes

Assignees

@madhusudhand madhusudhand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madhusudhand @matticbot @a8ci18n @taipeicoder @arthur791004