Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Picker: Sort the selected categories to the top and keep the order between them unchanged #97112

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Dec 5, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/10015

Proposed Changes

  • Sort the selected categories to the top and keep the order between them unchanged (the same as the API response by D167989-code) regardless of the order of selected goals.

Why are these changes being made?

Testing Instructions

  • Create a new site
  • On the Goals screen, select "Sell services or digital goods" first and then "Publish a blog"
  • On the Design Picker screen, ensure the order of selected categories are "Blog, Business, Store" (The feature & subject will be separated after we update the UI)
  • Go back to the Goals screen
  • Reverse the selected order. That is, select "Publish a blog" first and then "Sell services or digital goods"
  • On the Design Picker screen, ensure the order of selected categories are still "Blog, Business, Store"

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Dec 5, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/design-picker-category-order on your sandbox.

@arthur791004 arthur791004 requested a review from a team December 6, 2024 05:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@@ -84,7 +84,7 @@ const GoalsStep: Step = ( { navigation } ) => {
...commonEventProps,
intent,
goals: serializeGoals( goals ),
combo: goals.sort().join( ',' ),
combo: goals.slice().sort().join( ',' ),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to clone the array of the goals to avoid the sort function mutate the original array.

@arthur791004 arthur791004 changed the title Design Picker: Sort the categories based on the order of the selected goals Design Picker: Sort the selected categories to the top and keep the order between them unchanged Dec 6, 2024
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arthur791004 arthur791004 merged commit ba68889 into trunk Dec 6, 2024
15 checks passed
@arthur791004 arthur791004 deleted the feat/design-picker-category-order branch December 6, 2024 05:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants