-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Picker: Sort the selected categories to the top and keep the order between them unchanged #97112
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@@ -84,7 +84,7 @@ const GoalsStep: Step = ( { navigation } ) => { | |||
...commonEventProps, | |||
intent, | |||
goals: serializeGoals( goals ), | |||
combo: goals.sort().join( ',' ), | |||
combo: goals.slice().sort().join( ',' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have to clone the array of the goals to avoid the sort function mutate the original array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related to https://github.com/Automattic/dotcom-forge/issues/10015
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist