Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear charts & remove duplicate days buttons #97110

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

j6ll
Copy link
Member

@j6ll j6ll commented Dec 5, 2024

Proposed Changes

  • Fixes DSP issues 2899 & 2890
  • Don't show the last X days button if X is equal to "whole campaign" - means we have 2 buttons that do the same thing.
  • Make the line chart linear, this should more accurately represent the data than the previous curved lines

Testing Instructions

Code review should be adequate

  • Find a 7-day campaign
  • It should only show the "whole campaign" and not "last 7 days" button
  • It can show "today/yesterday" if it is still active
  • Charts should be linear

Screenshot 2024-12-05 at 11 03 55

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@j6ll j6ll changed the title Jamesgill23/2890 2889 chart improvements Linear charts & remove duplicate days buttons Dec 5, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
Copy link
Contributor

@therocket-gr therocket-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and works as described
code changes LGTM

Screenshot 2024-12-05 at 1 10 07 PM Screenshot 2024-12-05 at 1 10 04 PM

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug jamesgill23/2890-2889-chart-improvements on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@j6ll j6ll merged commit 158fcb1 into trunk Dec 5, 2024
18 checks passed
@j6ll j6ll deleted the jamesgill23/2890-2889-chart-improvements branch December 5, 2024 11:19
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
mehmoodak pushed a commit that referenced this pull request Dec 6, 2024
* Make the charts linear
* Remove the X days buttons if X days is the same as whole campaign length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants