Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Picker: Map goals to multi taxonomies #97101

Merged

Conversation

arthur791004
Copy link
Contributor

Related to https://github.com/Automattic/dotcom-forge/issues/10015

Proposed Changes

  • Map goals to multi taxonomies. Will improve the sorting in the follow-up PR.

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Dec 5, 2024
@arthur791004 arthur791004 requested a review from a team December 5, 2024 06:54
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004 arthur791004 force-pushed the feat/design-picker-map-goals-to-multi-taxonomies branch 2 times, most recently from 242ab24 to af241be Compare December 5, 2024 07:51
@arthur791004 arthur791004 force-pushed the feat/design-picker-map-goals-to-multi-taxonomies branch from af241be to 40a1758 Compare December 5, 2024 08:45
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
However. the filter list didn't always match the mapping order. I assume we'll follow this up in a later PR.

@arthur791004 arthur791004 merged commit 7776477 into trunk Dec 5, 2024
11 checks passed
@arthur791004 arthur791004 deleted the feat/design-picker-map-goals-to-multi-taxonomies branch December 5, 2024 10:06
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants