In progress: Don't recommend transferring unsupported domain and don't connect unregistered domains #97098

StevenPartridge · 2024-12-05T03:34:57Z

Introduces logic to hide the recommendation to transfer an unsupported domain to wp.com

related to code-D166359

Related to #

Proposed Changes

Hides suggestion to transfer when the tld is not supported

Don't continue forward to the Transfer/Connect step at all if the domain is not Registered

Why are these changes being made?

To avoid asking customers to do things that are unsupported, giving a false impression

Testing Instructions

Apply this diff
Apply this backend diff: 170089-ghe-Automattic/wpcom
Build and proxy Calypso
Proxy for Sandbox
Navigate to a site you own
Navigate to Upgrades > Domains
Select 'Use a Domain I Own' from the dropdown

TEST CASE 1 - Unsupported, Registered Domain:

Enter 'google.pl', or another UNSUPPORTED TLD that is definitely registered (elsewhere)
On the next page, ensure the "Transfer [Recommended]" side banner is not shown

TEST CASE 2 - Unsupported, Unregistered Domain:

Enter 'veryfakedomain12345.pl' or another Unsupported TLD that is certainly not registered here or anywhere
You should see the same error that you would see with 'veryfakedomain12345.com' (a supported tld), suggesting you seek further answers on the Domain Search page

TEST CASE 3 - Supported Unregistered Domain:

Enter 'veryfakedomain12345.com' or another Supported TLD that is unequivocally not registered here or anywhere
You should see the same error from Test Case 2, this is the current experience and should be unchanged

TEST CASE - Supported Registered Domain:

Enter 'google.com' or another supported TLD that is unquestionably registered elsewhere
On the next page, ensure the "Transfer [Recommended]" side banner IS shown, as per the current (and unchanged) functionality

github-actions · 2024-12-05T03:35:12Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-129812

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-129812&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-129812&env=a8c-for-agencies

matticbot · 2024-12-05T03:39:43Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug nomado-96192/disable-connecting-registrable-domain on your sandbox.

matticbot · 2024-12-05T03:41:26Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~21 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
domains                     +39 B  (+0.0%)      +21 B  (+0.0%)
update-design-flow          +12 B  (+0.0%)       +5 B  (+0.0%)
link-in-bio-tld-flow        +12 B  (+0.0%)       +5 B  (+0.0%)
copy-site-flow              +12 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~5 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains        +12 B  (+0.0%)       +5 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

…d domain to wp.com

StevenPartridge · 2025-01-15T01:30:53Z

client/components/domains/use-my-domain/utilities/get-availability-error-message.js

@@ -8,7 +8,7 @@ export function getAvailabilityErrorMessage( { availabilityData, domainName, sel
 	const { status, mappable, maintenance_end_time, other_site_domain, other_site_domain_only } =
 		availabilityData;

-	if ( domainAvailability.AVAILABLE === status ) {
+	if ( [ status, mappable ].includes( domainAvailability.AVAILABLE ) ) {


This change means that a domain that is unregistered will always lead the user to search for a domain to register:

I was worried that adding the mappable value here might have unintended side-effects, but I think the only place where mappable can be set to "available" is in the new check added in 170089-ghe-Automattic/wpcom, so it should be fine 🤔

StevenPartridge · 2025-01-15T01:32:32Z

client/components/domains/connect-domain-step/index.jsx

@@ -335,7 +335,7 @@ function ConnectDomainStep( {
 			return <div className={ baseClassName + '__sidebar-placeholder' }></div>;
 		}

-		if ( ! isStepStart ) {
+		if ( ! isStepStart || ! domainSetupInfo?.data?.is_supported_tld ) {


This is to hide this box, on the right, to avoid suggesting an unsupported action

leonardost

LGTM! Tested this alongside 170089-ghe-Automattic/wpcom and worked as expected, thanks for this improvement!

I've tried all the test cases mentioned in the test plan:

Unsupported TLD + unregistered domain, e.g. adsifhjiuwehf.pl
Unsupported TLD + registered domain, aniagotuje.pl
Supported TLD + unregistered domain, iasudhfiuashdfiu.com
Supported TLD + registered domain, google.com

And all worked correctly

leonardost · 2025-01-15T21:17:25Z

client/components/domains/use-my-domain/utilities/get-availability-error-message.js

@@ -8,7 +8,7 @@ export function getAvailabilityErrorMessage( { availabilityData, domainName, sel
 	const { status, mappable, maintenance_end_time, other_site_domain, other_site_domain_only } =
 		availabilityData;

-	if ( domainAvailability.AVAILABLE === status ) {
+	if ( [ status, mappable ].includes( domainAvailability.AVAILABLE ) ) {


I was worried that adding the mappable value here might have unintended side-effects, but I think the only place where mappable can be set to "available" is in the new check added in 170089-ghe-Automattic/wpcom, so it should be fine 🤔

StevenPartridge added the [Status] In Progress label Dec 5, 2024

StevenPartridge requested a review from a team as a code owner December 5, 2024 03:34

matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 5, 2024

StevenPartridge mentioned this pull request Dec 5, 2024

Domains: Domain Connection flow can accept unregistered domains #96192

Open

StevenPartridge force-pushed the nomado-96192/disable-connecting-registrable-domain branch from 74083ce to 869b9d8 Compare December 10, 2024 21:06

StevenPartridge removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 19, 2024

Introduces logic to hide the recommendation to transfer an unsupporte…

7a22bd7

…d domain to wp.com

StevenPartridge force-pushed the nomado-96192/disable-connecting-registrable-domain branch from 869b9d8 to 7a22bd7 Compare January 14, 2025 23:29

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025

Same error for either case where a domain is available for registration

796e76d

StevenPartridge commented Jan 15, 2025

View reviewed changes

StevenPartridge removed the [Status] In Progress label Jan 15, 2025

leonardost approved these changes Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

In progress: Don't recommend transferring unsupported domain and don't connect unregistered domains #97098

In progress: Don't recommend transferring unsupported domain and don't connect unregistered domains #97098

StevenPartridge commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited by matticbot

Loading

matticbot commented Dec 5, 2024 •

edited

Loading

matticbot commented Dec 5, 2024 •

edited

Loading

StevenPartridge Jan 15, 2025

leonardost Jan 15, 2025

StevenPartridge Jan 15, 2025

leonardost left a comment •

edited

Loading

leonardost Jan 15, 2025

In progress: Don't recommend transferring unsupported domain and don't connect unregistered domains #97098

Are you sure you want to change the base?

In progress: Don't recommend transferring unsupported domain and don't connect unregistered domains #97098

Conversation

StevenPartridge commented Dec 5, 2024 • edited Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

github-actions bot commented Dec 5, 2024 • edited by matticbot Loading

matticbot commented Dec 5, 2024 • edited Loading

matticbot commented Dec 5, 2024 • edited Loading

StevenPartridge Jan 15, 2025

Choose a reason for hiding this comment

leonardost Jan 15, 2025

Choose a reason for hiding this comment

StevenPartridge Jan 15, 2025

Choose a reason for hiding this comment

leonardost left a comment • edited Loading

Choose a reason for hiding this comment

leonardost Jan 15, 2025

Choose a reason for hiding this comment

StevenPartridge commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited by matticbot

Loading

matticbot commented Dec 5, 2024 •

edited

Loading

matticbot commented Dec 5, 2024 •

edited

Loading

leonardost left a comment •

edited

Loading