Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: use today as shortcut ending date / default ending date #97096

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Dec 5, 2024

Related to p1733354174044339-slack-C0438NHCLSY

Proposed Changes

  • Make Last x days end yesterday makes a lot of sense if the highlight cards are still up at the top of the page. But now that they respect the date range, then incomplete periods shouldn't be a problem anymore, because users are aware today hasn't ended yet.

Why are these changes being made?

Testing Instructions

  • Open Calypso Live for a p2 /stats/day/your-site.com
  • Ensure the default date range ending today
  • Click some of the date range shortcuts
  • Ensure the ranges end today as well
  • Apply the range
  • Ensure everything looks okay
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@kangzj kangzj added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 5, 2024
@kangzj kangzj requested a review from dognose24 December 5, 2024 01:17
@kangzj kangzj self-assigned this Dec 5, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 5, 2024
@kangzj kangzj marked this pull request as ready for review December 5, 2024 01:20
@kangzj kangzj changed the title Stats: use today as ending date Stats: use today as shortcut ending date / default ending date Dec 5, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert/use-today-as-end-of-last-x-days on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 5, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~23 bytes removed 📉 [gzipped])

name                           parsed_size           gzip_size
stats                               -100 B  (-0.0%)      -14 B  (-0.0%)
plugins                              -12 B  (-0.0%)       -5 B  (-0.0%)
media                                -12 B  (-0.0%)       -5 B  (-0.0%)
jetpack-cloud-agency-sites-v2        -12 B  (-0.0%)       -4 B  (-0.0%)
backup                               -12 B  (-0.0%)       -4 B  (-0.0%)
activity                             -12 B  (-0.0%)       -4 B  (-0.0%)
a8c-for-agencies-sites               -12 B  (-0.0%)       -4 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~12 bytes removed 📉 [gzipped])

name                                               parsed_size           gzip_size
async-load-store-app-store-stats-listview                -12 B  (-0.0%)       -7 B  (-0.0%)
async-load-store-app-store-stats                         -12 B  (-0.0%)       -7 B  (-0.0%)
async-load-design-playground                             -12 B  (-0.0%)       -5 B  (-0.0%)
async-load-design-blocks                                 -12 B  (-0.0%)       -5 B  (-0.0%)
async-load-design                                        -12 B  (-0.0%)       -5 B  (-0.0%)
async-load-calypso-post-editor-media-modal               -12 B  (-0.0%)       -5 B  (-0.0%)
async-load-calypso-post-editor-editor-media-modal        -12 B  (-0.0%)       -5 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@dognose24 dognose24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dognose24 dognose24 merged commit e36d212 into trunk Dec 5, 2024
12 checks passed
@dognose24 dognose24 deleted the revert/use-today-as-end-of-last-x-days branch December 5, 2024 08:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
mehmoodak pushed a commit that referenced this pull request Dec 6, 2024
* use today as ending date

* fix start date calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants