Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP: Apply the design updates #97087

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

valterlorran
Copy link
Contributor

Closes #97082

Proposed Changes

  • Fix the icons on the Authorization Step.
  • Fix the error message in case we can store the Credentials.

Captura de Tela 2024-12-04 às 17 12 03

Why are these changes being made?

  • There were a few outstanding design issues that we needed to tackle separately, beyond that we collected feedback to the new error we introduced.
  • p1733342097901209/1733315236.570409-slack-C0Q664T29

Testing Instructions

  • Use calypso live to avoid the SSL error when trying to authenticate.
  • Go through the migration process until you reach the Credentials step.
  • Then update the URL to point to the /setup/site-migration/site-migration-application-password-authorization path. Keep the current parameters, and add the authorizationUrl, which could be a valid authorization URL for the Application Passwords: https://example.com/wp-admin/authorize-application.php&app_id=1083d914-d9f8-47ec-b49b-55d206104730&app_name=Test
  • You should see the default view, inviting the user to Authorize. Click on the "Authorize" button.
  • You should be redirected to your test site.
  • Approve the new Application Password.
  • You should be redirected to the Authorization step and should see a loading state.
  • After the loading state, you'll probably see the Authorization step with an error message, because the endpoint that stores the Password will fail because you don't have the ticket.
  • So far this should be enough to test.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@valterlorran valterlorran requested a review from a team December 4, 2024 20:18
@valterlorran valterlorran self-assigned this Dec 4, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 4, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/layout-authorization-step on your sandbox.

@andregardi
Copy link
Contributor

I followed the instructions and got the success screen.
image

I don't see any ticket open on Zendesk for me even with the search. But I suspect that maybe I have a open ticket, that is not appearing on Zendesk at the moment. Let me dig a bit more into that.

@andres-blanco
Copy link
Contributor

The CI errors seem related to the diff

Copy link
Contributor

@andregardi andregardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @valterlorran!
Looks good to me.

image

@valterlorran valterlorran merged commit f254f15 into trunk Dec 5, 2024
11 checks passed
@valterlorran valterlorran deleted the fix/layout-authorization-step branch December 5, 2024 14:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 5, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17048091

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @valterlorran for including a screenshot in the description! This is really helpful for our translators.

mehmoodak pushed a commit that referenced this pull request Dec 6, 2024
* Apply the design updates

* Fix tests
@a8ci18n
Copy link

a8ci18n commented Dec 11, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Passwords: Inconsistency on the Figma design
5 participants