Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Fix going back from Checkout to Stepper #97074

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Dec 4, 2024

Fixes: #96888

Reverts https://github.com/Automattic/wp-calypso/pull/95244/files#diff-d6bc20bcdcb4a999ce96bb33bf6f986392311a3800680220300a7477733748f7R101-R112.

Proposed Changes

This corrects a mistake in the onboarding flow that replaces the plans route when navigating to create-site route.

Why are these changes being made?

So that going back from checkout to /plans works in the onboarding flow.

Testing Instructions

@matticbot
Copy link
Contributor

matticbot commented Dec 4, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/going-back-from-checkout on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@escapemanuele escapemanuele requested a review from a team December 4, 2024 18:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@escapemanuele escapemanuele marked this pull request as ready for review December 4, 2024 18:35
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@escapemanuele escapemanuele merged commit 1d05869 into trunk Dec 5, 2024
11 checks passed
@escapemanuele escapemanuele deleted the fix/going-back-from-checkout branch December 5, 2024 10:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: Browser back from Checkout to Plans does not reach Domains
3 participants