Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Check partial period date label with customRange #97065

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

dognose24
Copy link
Contributor

Related to https://github.com/Automattic/red-team/issues/286

Proposed Changes

  • Compare chart starts and end dates with the partial week period date label for accurate data range on the tooltip.

Why are these changes being made?

  • Make the partial week bar have a more accurate tooltip date label.

Testing Instructions

  • Spin this change up with the Calypso Live branch.
  • Navigate to Stats > Traffic page with the feature flag: ?flags=stats/new-date-filtering.
  • Pick a date range and apply the period Weeks.
  • Hover on the first and last bars on the chart.
  • Ensure the date label starts or ends with the applied date range.
截圖 2024-12-04 晚上11 45 30

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@dognose24 dognose24 added the [Feature] Stats Everything related to our analytics product at /stats/ label Dec 4, 2024
@dognose24 dognose24 requested a review from a team December 4, 2024 15:56
@dognose24 dognose24 self-assigned this Dec 4, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 4, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~165 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +229 B  (+0.0%)      +80 B  (+0.0%)
home        +222 B  (+0.0%)      +85 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats_fix_range_period_date_label on your sandbox.

Copy link
Contributor

@Initsogar Initsogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Works as described!

image

Date Before After
Start CleanShot 2024-12-04 at 16 15 51@2x CleanShot 2024-12-04 at 16 16 38@2x
End CleanShot 2024-12-04 at 16 17 36@2x CleanShot 2024-12-04 at 16 18 01@2x

@dognose24 dognose24 merged commit 1bfef66 into trunk Dec 6, 2024
14 of 15 checks passed
@dognose24 dognose24 deleted the update/stats_fix_range_period_date_label branch December 6, 2024 04:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants