Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect left padding of checkout address form messages #97063

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Dec 4, 2024

Related to #95816

Proposed Changes

I propose to fix the incorrect space that appears on the left side of checkout billing address form validation messages.

Why are these changes being made?

To provide consistent UI.

Testing Instructions

  1. Open Calypso locally or use a Calypso Live link
  2. Navigate to https://wordpress.com/domains/
  3. Choose a domain and proceed through the following steps to add it to the cart
  4. Edit contact information fields and ensure they are empty
  5. Click 'Continue to payment'
  6. Confirm that validation messages under fields are aligned correctly

Screenshot 2024-12-04 at 16 16 18

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@wojtekn wojtekn added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Dec 4, 2024
@wojtekn wojtekn requested a review from okmttdhr December 4, 2024 15:23
@wojtekn wojtekn self-assigned this Dec 4, 2024
@wojtekn wojtekn requested a review from a team as a code owner December 4, 2024 15:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/field-validation-message-spacing on your sandbox.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. I wonder when that regression happened. 🤔

@wojtekn
Copy link
Contributor Author

wojtekn commented Dec 4, 2024

@sirbrillig thanks for reviewing it.

I think it might have popped out after adding left padding in 1954928. In wp-contact-form.tsx we have not been setting the the left padding, so the other one was used.

@wojtekn wojtekn merged commit 3145f3e into trunk Dec 5, 2024
15 of 16 checks passed
@wojtekn wojtekn deleted the fix/field-validation-message-spacing branch December 5, 2024 07:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groundskeeping Issues handled through Dotcom Groundskeeping rotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants