Help Center: Use default values on case of error #97053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
| messages: data.messages, | ||
| odieId: Number( data.chat_id ), | ||
| messages: data.messages || [], | ||
| odieId: Number( data.chat_id ) || chatId, |
There was a problem hiding this comment.
Are usually data.chat_id and chatId different?
There was a problem hiding this comment.
they should be the same
escapemanuele
changed the title
escapemanuele
approved these changes
Dec 4, 2024
github-actions
bot
removed
the
[Status] Needs Review
mehmoodak
pushed a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit oppinionated but the hc should be available no matter what.
This PR makes things a bit more resilient.
In case we fail to load a odie chat, the help center should continue working.
Related to p1733303607767299/1733233447.208929-slack-C02T4NVL4JJ
Proposed Changes
Why are these changes being made?
Testing Instructions
sourcesto be string before iterating. fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Serfg%2Qncv%2Qcyhtvaf%2Sraqcbvagf%2Sbqvr%2Qnffvfgnag.cuc%3Se%3Q00nq0488%23482-og