Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Recent Feed Overhaul: Launch the feature #97022

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

allilevine
Copy link
Member

@allilevine allilevine commented Dec 3, 2024

Proposed Changes

  • Enable the flag in all environments.

Why are these changes being made?

  • pe7F0s-2iv-p2

Testing Instructions

  • Test that the feature loads on Calypso Live and local without the flag.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@allilevine allilevine self-assigned this Dec 3, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 3, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/reader-recent-feed-overhaul-flag-config on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@allilevine allilevine marked this pull request as ready for review December 3, 2024 16:59
@allilevine allilevine force-pushed the update/reader-recent-feed-overhaul-flag-config branch from f473c56 to 97bd65e Compare December 6, 2024 21:57
@allilevine allilevine changed the title Reader Recent Feed Overhaul: Soft launch the feature Reader Recent Feed Overhaul: Launch the feature Dec 6, 2024
@allilevine allilevine requested a review from a team December 9, 2024 20:39
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
Copy link
Contributor

@arcangelini arcangelini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configs look good 👍

Tested in live and local without proxy and reader loaded as expected and worked properly from my smoke check.

@allilevine allilevine merged commit 791e40a into trunk Dec 10, 2024
13 of 14 checks passed
@allilevine allilevine deleted the update/reader-recent-feed-overhaul-flag-config branch December 10, 2024 14:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants