Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: redirect hourly to daily for summary pages #96751

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Nov 25, 2024

Related to #96656 (review)

Proposed Changes

  • Redirect hourly to daily for summary pages, as it's not supported

cc @a8ck3n

Why are these changes being made?

  • Bugfix

Testing Instructions

  • Open Calypso Live /stats/hour/jetpack.com?chartStart=2024-11-25&chartEnd=2024-11-25&flags=stats%2Fnew-date-filtering
  • Click view more for a module
  • Ensure it takes you to daily view of summary page
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@kangzj kangzj added the [Feature] Stats Everything related to our analytics product at /stats/ label Nov 25, 2024
@kangzj kangzj requested a review from a team November 25, 2024 22:08
@kangzj kangzj self-assigned this Nov 25, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 25, 2024
@kangzj kangzj marked this pull request as ready for review November 25, 2024 22:08
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/redirect-hourly-view-for-summary-page on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~22 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +144 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@kangzj kangzj merged commit 691bfd9 into trunk Nov 25, 2024
15 of 16 checks passed
@kangzj kangzj deleted the fix/redirect-hourly-view-for-summary-page branch November 25, 2024 23:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@a8ck3n a8ck3n mentioned this pull request Nov 26, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants