-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Recent Feed Overhaul: Match cog menu styles and update posts list styles #96748
Reader Recent Feed Overhaul: Match cog menu styles and update posts list styles #96748
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~42 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~327 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
render: ( { item }: { item: ReaderPost } ) => { | ||
return <RecentSeenField post={ getPostFromItem( item ) } />; | ||
const post = getPostFromItem( item ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the seen field and replaced it with an icon field that renders the icon in the DataViews mediaField
.
@import '@wordpress/base-styles/breakpoints'; | ||
@import "@wordpress/base-styles/breakpoints"; | ||
@import "@wordpress/base-styles/mixins"; | ||
@import "@wordpress/dataviews/build-style/style.css"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We import these styles in other DataViews implementations on Dotcom.
border-top: 1px solid var( --studio-gray-0 ); | ||
|
||
&.is-selected + li { | ||
border-top: 1px solid var( --studio-gray-0 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is preventing a blue border under the selected item.
} | ||
} | ||
.dataviews-view-list__item-wrapper { | ||
background-color: #f7faff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changing the DataViews selected background color to the one in our design.
border-radius: 50%; | ||
width: 24px; | ||
height: 24px; | ||
background-color: transparent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This style changes the shape of the DataViews' media field.
max-width: 38px; | ||
align-self: flex-end; | ||
flex-shrink: 0; | ||
.dataviews-view-list__item { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This style changes the padding of the DataViews items to match the design / maximize horizontal space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM
Related to https://github.com/Automattic/loop/issues/222
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist