chore(deps): update dawidd6/action-download-artifact action to v3 [security] - autoclosed #96735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2
->v3
GitHub Vulnerability Alerts
GHSA-5xr6-xhww-33m4
Summary
In versions of
dawidd6/action-download-artifact
before v6, a repository's forks were also searched by default when attempting to find matching artifacts. This could be exploited by an unprivileged attacker to introduce compromised artifacts (such as malicious executables) into a privileged workflow context, as creating a fork requires no privileges.Users should immediately upgrade to v6 or newer, which changes the default behavior to avoid searching forks for matching artifacts. Users who cannot upgrade should explicitly set
allow_forks: false
to disable searching forks for artifacts.Details
GitHub's artifact storage for workflows does not natively distinguish between artifacts created by a repository and artifacts created by forks of that repository. As a result, attempting to retrieve the "latest" artifact for a workflow run can return artifacts produced by a fork, rather than its upstream.
Because any GitHub user can create a fork of a public repository, this allows for artifact poisoning in the following scenarios (as well as potentially others):
alice/foo
runsbuild.yml
, producingbuild.exe
alice/foo
runspublish.yml
, which usesaction-download-artifact@v5
to retrieve the latestbuild.exe
frombuild.yml
To compromise
publish.yml
in this scenario, Mallory forksalice/foo
tomallory/foo
, and then modifiesbuild.yml
to produce a compromisedbuild.exe
. Mallory can then repeatedly trigger their copy ofbuild.yml
to ensure that their compromisedbuild.exe
is always the latest artifact, meaning that Alice'spublish.yml
will retrieve it.Additional details on this vulnerability can be found in this blog post from 2022:
Impact
This vulnerability impacts all repositories on GitHub that use
action-download-artifacts@v5
or older and do not disableallow_forks: true
, which is the default.If a repository is affected, the severity ranges from downstream contamination (such as publishing attacker-controlled artifacts) to direct workflow compromise (if the retrieved artifact is then executed in a privileged workflow context, such as
push
orpull_request_target
).Release Notes
dawidd6/action-download-artifact (dawidd6/action-download-artifact)
v3
Compare Source
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.