Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Align period header styles with design #96723

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Stats: Align period header styles with design #96723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bdc695
Remove unnecessary banner
dognose24 Nov 25, 2024
3b710aa
Align StatsPeriodHeader styles with design
dognose24 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions client/my-sites/stats/site.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,14 +456,6 @@ class StatsSite extends Component {
isOdysseyStats={ isOdysseyStats }
statsPurchaseSuccess={ context.query.statsPurchaseSuccess }
/>
{ isNewDateFilteringEnabled && (
<div
className="stats-new-date-filtering-callout"
style={ { background: 'antiquewhite', maring: '24px', padding: '24px' } }
>
<p>New date filtering enabled.</p>
</div>
) }
{ ! isNewDateFilteringEnabled && (
// @TODO: remove highlight section completely once flag is released
<HighlightsSection siteId={ siteId } currentPeriod={ defaultPeriod } />
Expand Down
8 changes: 7 additions & 1 deletion client/my-sites/stats/stats-period-header/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
flex-wrap: wrap;
align-items: center;
justify-content: center;
margin: 16px 0;
// .stats-content has a gap already, so the .stats__period-header from the new design only needs margin-top.
margin-top: 16px;

.stats-content & {
margin: 16px 0;
}

.period {
font-family: $brand-serif;
Expand All @@ -20,6 +25,7 @@
// this new selector removes padding only for the date filtering design
&.stats-period-navigation__is-with-new-date-filtering {
padding: 0;
align-items: center;

@media (max-width: $break-medium) {
padding: 0 16px;
Expand Down
Loading