Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites Dashboard: Remove max-width constraints for full-width title alignment #96713

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Nov 25, 2024

Related to #

Proposed Changes

This PR removes max-width constraints for full-width title alignment.

Why are these changes being made?

p1732272905062089-slack-CRWCHQGUB

Testing Instructions

  • Go to /sites
  • Ensure the title is aligned with DataViews in the large view
Screenshot 2024-11-25 at 12 13 05

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@okmttdhr okmttdhr marked this pull request as ready for review November 25, 2024 03:13
@okmttdhr okmttdhr self-assigned this Nov 25, 2024
@okmttdhr okmttdhr requested a review from a team November 25, 2024 03:14
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@okmttdhr okmttdhr requested a review from matt-west November 25, 2024 03:14
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr merged commit 061c55a into trunk Nov 25, 2024
15 checks passed
@okmttdhr okmttdhr deleted the update/title-full-width branch November 25, 2024 04:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@taipeicoder
Copy link
Contributor

Sorry for the late review, we also need to remove the max-width for the banner.

Screenshot 2024-11-25 at 3 44 42 PM

@okmttdhr
Copy link
Member Author

Thanks for your comment. I'll follow up on this!

@matt-west
Copy link
Contributor

Thanks for fixing this @okmttdhr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants