-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: fix dashboard header/tab alignment #96685
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, @Initsogar! I'm holding on merging/deploying, as @kangzj might want to test it further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @myhro for the fix. Happy for it to ship, but it'll be even better if you could take a look at the margin of the Jetpack log0 for screen width < 600px for Odyssey Stats. Thanks again for the fix.
@kangzj I've pushed a fix for the header alignment in Odyssey Stats. Can you please take a look again?
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix 🚀
Closes Automattic/red-team#256.
Proposed Changes
Fix the alignment of the header and navigation tabs in the Stats dashboard on Calypso Blue.
Why are these changes being made?
These changes are being implemented to align the header and navigation tabs with the similar design found in the WP Admin dashboard.
Testing Instructions
Stats
section in the sidebar of a given site./stats/day/artistic-ukulele-worm.jurassic.ninja
.Traffic / Insights / Subscribers
navigation bar compared to theJetpack Stats
header.Note
The length of the underline highlighting the active tab has been shortened slightly. This adjustment reflects the fact that the first item is no longer centered in its column. However, this behavior is consistent with what is observed in WP Admin:
Pre-merge Checklist