Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack AI Logo Generator: Preserve user language when getting the first prompt #96677

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Nov 22, 2024

Closes #96665.

Proposed Changes

The prompt should be in the users' locale. Here's an example:

image

Why are these changes being made?

To maintain consistency with the users' language. Our previous prompt said to preserve the language but didn't say what the language was. Because we had examples in English and Spanish, it was preserving Spanish instead as it was the most comprehensive example.

Testing Instructions

Change your accounts' language to English and open the Logo Generator on any site. You should get the first prompt in English. Change the language to something other than English (Afrikaans, for example) and verify that the prompt is in Afrikaans. In my screenshot, it's in Italian.

@zaguiini zaguiini added the AI OpenAI / GPT-3 / DALLe and others label Nov 22, 2024
@zaguiini zaguiini requested review from CGastrell, jeherve, Lochlaer and a team November 22, 2024 14:25
@zaguiini zaguiini self-assigned this Nov 22, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 22, 2024
@zaguiini zaguiini requested a review from dhasilva November 22, 2024 14:28
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/jetpack-ai-prompt-preserves-account-locale on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~44 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
home        +72 B  (+0.0%)      +44 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch!
The intention was to detect the language from the site's name and description, but this approach is better.

Copy link
Contributor

@candy02058912 candy02058912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although for Chinese, the AI can't distinguish between Traditional Chinese and Simplified Chinese, but that's a different issue.

@zaguiini zaguiini merged commit 6d040c2 into trunk Nov 25, 2024
19 of 20 checks passed
@zaguiini zaguiini deleted the fix/jetpack-ai-prompt-preserves-account-locale branch November 25, 2024 12:19
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI OpenAI / GPT-3 / DALLe and others
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack AI logo generator modal is in the wrong language and has text overflow
4 participants