-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI Logo Generator: Preserve user language when getting the first prompt #96677
Jetpack AI Logo Generator: Preserve user language when getting the first prompt #96677
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~44 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good catch!
The intention was to detect the language from the site's name and description, but this approach is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although for Chinese, the AI can't distinguish between Traditional Chinese and Simplified Chinese, but that's a different issue.
Closes #96665.
Proposed Changes
The prompt should be in the users' locale. Here's an example:
Why are these changes being made?
To maintain consistency with the users' language. Our previous prompt said to preserve the language but didn't say what the language was. Because we had examples in English and Spanish, it was preserving Spanish instead as it was the most comprehensive example.
Testing Instructions
Change your accounts' language to English and open the Logo Generator on any site. You should get the first prompt in English. Change the language to something other than English (Afrikaans, for example) and verify that the prompt is in Afrikaans. In my screenshot, it's in Italian.