Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Update to fix header consistency #96661

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

annacmc
Copy link
Contributor

@annacmc annacmc commented Nov 22, 2024

Related to https://github.com/Automattic/red-team/issues/271

Proposed Changes

  • Ensure the days consistently show date ranges with exact dates

Why are these changes being made?

  • To ensure header consistency for the Date Filtering for the Traffic Page project

Testing Instructions

  • Open up the Calypso live branch
  • Apply the stats/new-date-filtering flag
  • Try different date ranges and selections, ensuring that the title continues to show the exact + correct date ranges
  • Check other stats locations and triple check this doesn't affect anything else, anywhere else
  • Select a full year date range (eg. 1st jan - 31st dec) and check that just the year is shown (eg. 2023)
  • Select a full month date range (eg. 1st jan - 31st jan) and check that just the month + year is shown (eg. October 2024)
  • Select a single day, and check just the date is showing (eg. November 22, 2024)

image
image
image
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@annacmc annacmc added the [Feature] Stats Everything related to our analytics product at /stats/ label Nov 22, 2024
@annacmc annacmc self-assigned this Nov 22, 2024
@annacmc annacmc requested a review from a team November 22, 2024 07:21
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 22, 2024
@annacmc annacmc marked this pull request as ready for review November 22, 2024 07:24
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug updat/stats-fix-header-consisitency on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Nov 22, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~108 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +526 B  (+0.0%)     +108 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~104 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-store-app-store-stats-listview       +514 B  (+0.2%)     +104 B  (+0.1%)
async-load-store-app-store-stats                +514 B  (+0.1%)     +104 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@dognose24 dognose24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangzj kangzj merged commit 6ea0f58 into trunk Nov 24, 2024
13 checks passed
@kangzj kangzj deleted the updat/stats-fix-header-consisitency branch November 24, 2024 20:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants