Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UTM card learn more link #96651

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

CGastrell
Copy link
Contributor

@CGastrell CGastrell commented Nov 21, 2024

Fallback to external link as InlineSupportLink component refuses to render properly.

Related to #87925
Related to #96596

Proposed Changes

This PR changes the link on UTM card upsell overlay to external support link

Why are these changes being made?

Because InlineSupportLink can't render under specific conditions

Testing Instructions

The UTM card shows an overlay when no upgrade/plan is purchased. The overlay should now show a "Learn more" link.

Odyssey stats was already showing this link, yet Calypso failed to render it. Test on calypso.localhost:3000/stats/day/some-site-of-yours

Before:
image

After:
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@CGastrell CGastrell added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Fix Inbound Use when a fix is in unreleased component labels Nov 21, 2024
@CGastrell CGastrell requested review from a team November 21, 2024 21:23
@CGastrell CGastrell self-assigned this Nov 21, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 21, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~46 bytes removed 📉 [gzipped])

name   parsed_size           gzip_size
stats       -126 B  (-0.0%)      -46 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1693 bytes removed 📉 [gzipped])

name                                       parsed_size           gzip_size
async-load-store-app-store-stats-listview      -3002 B  (-1.1%)     -889 B  (-1.1%)
async-load-store-app-store-stats               -2989 B  (-0.8%)     -850 B  (-0.7%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes the immediate problem.

Copy link
Contributor

@dognose24 dognose24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@kangzj kangzj merged commit 08c4bf7 into trunk Nov 24, 2024
16 of 17 checks passed
@kangzj kangzj deleted the fix/stats-card-upsell-overlay-link branch November 24, 2024 20:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/ [Status] Fix Inbound Use when a fix is in unreleased component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants