-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UTM card learn more link #96651
Fix UTM card learn more link #96651
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~46 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1693 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fixes the immediate problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏼
Fallback to external link as InlineSupportLink component refuses to render properly.
Related to #87925
Related to #96596
Proposed Changes
This PR changes the link on UTM card upsell overlay to external support link
Why are these changes being made?
Because InlineSupportLink can't render under specific conditions
Testing Instructions
The UTM card shows an overlay when no upgrade/plan is purchased. The overlay should now show a "Learn more" link.
Odyssey stats was already showing this link, yet Calypso failed to render it. Test on calypso.localhost:3000/stats/day/some-site-of-yours
Before:
After:
Pre-merge Checklist