-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: add support for new pressable enterprise plans in marketplace #96647
A4A: add support for new pressable enterprise plans in marketplace #96647
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~104 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~17467 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
71fecca
to
e7776af
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
4a77a55
to
1d1b099
Compare
client/a8c-for-agencies/sections/marketplace/pressable-overview/lib/get-pressable-plan.ts
Outdated
Show resolved
Hide resolved
While testing, I noticed that when you own enterprise plan, if switching tab to On a side note, our code around sliders and marketplace is growing, and maybe we could re-visit it in the future to see if it's need some refactoring. |
Ah, nice catch. Yeah it does seem like something should get disabled here
Agreed - I think some of the code in these components could be simplified |
I've changed it so the "Shared Resource Plans" tab becomes disabled when you already own Business 150 or any Signature plan to prevent the user from buying a lower or the same plan. |
@travisw Great work. Tested both regular purchases and referrals. All seems to work well on the agency and client sides! Other than what Andrei pointed out, my only recommendation is a small one. Can we shrink the width of the tabs to be After that 🚢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust the max width of the tabs and we're golden!
ffa537e
to
f6e422f
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17019592 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @travisw for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Related to: https://github.com/Automattic/automattic-for-agencies-dev/issues/1466
P2: pfSQfS-tF-p2
Proposed Changes
Why are these changes being made?
Testing Instructions
public-api.wordpress.com
./marketplace/hosting/pressable
).Once D166722-code has shipped, also test purchasing the plansPre-merge Checklist