-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Black Friday 2024 card to the My Home screen #96610
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~208 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~22 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
3cff12a
to
8cdd02e
Compare
8cdd02e
to
9cf8217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
import './style.scss'; | ||
|
||
const Affiliates = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a typo. Maybe somethjing like BlackFriday2024
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that!
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pls update the headline to "Our Biggest Sale..."
And also use this promo visual for the image: nNq0GqvlzdQ5i3OgusUon9-fi-249_65735
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrdnhllr Headline and promo visual have been updated.
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17020359 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators. |
This reverts commit 3b56865.
1208f84
to
94c1c19
Compare
Translation for this Pull Request has now been finished. |
Related to #
Proposed Changes
This adds a task cards for the Black Friday 2024 promo.
More info: pcNC1U-1u6-p2#comment-1772
Testing Instructions
Sandbox
public-api.wordpress.com
Apply D166880-code and follow instructions
In
client/my-sites/customer-home/cards/tasks/black-friday-2024/index.jsx
append the coupon code from36568-pb
to theactionUrl
Go to
/home/{SITE_ID}?view=VIEW_POST_LAUNCH
You should see the Black Friday 2024 slide in the primary slider
Pre-merge Checklist