Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Black Friday 2024 card to the My Home screen #96610

Merged
merged 9 commits into from
Nov 28, 2024

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Nov 21, 2024

Related to #

Proposed Changes

This adds a task cards for the Black Friday 2024 promo.

  • the card will be visible in the primary slider for the Post Launch view

More info: pcNC1U-1u6-p2#comment-1772

Testing Instructions

  • Sandbox public-api.wordpress.com

  • Apply D166880-code and follow instructions

  • In client/my-sites/customer-home/cards/tasks/black-friday-2024/index.jsx append the coupon code from 36568-pb to the actionUrl

  • Go to /home/{SITE_ID}?view=VIEW_POST_LAUNCH

  • You should see the Black Friday 2024 slide in the primary slider

Screenshot 2024-11-26 at 08 41 51

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@claudiucelfilip claudiucelfilip self-assigned this Nov 21, 2024
@matticbot
Copy link
Contributor

matticbot commented Nov 21, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~208 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
home                                  +461 B  (+0.0%)     +164 B  (+0.0%)
plans                                  +67 B  (+0.0%)      +44 B  (+0.0%)
reader                                 +43 B  (+0.0%)      +23 B  (+0.0%)
plugins                                +43 B  (+0.0%)      +23 B  (+0.0%)
jetpack-cloud-plugin-management        +43 B  (+0.0%)      +23 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~22 bytes added 📈 [gzipped])

name                                                parsed_size           gzip_size
async-load-calypso-blocks-jitm-templates-home-task        +43 B  (+0.1%)      +22 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@claudiucelfilip claudiucelfilip force-pushed the add/black-friday-my-home-card branch 2 times, most recently from 3cff12a to 8cdd02e Compare November 25, 2024 08:37
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@claudiucelfilip claudiucelfilip force-pushed the add/black-friday-my-home-card branch from 8cdd02e to 9cf8217 Compare November 25, 2024 09:14
Copy link
Contributor

@southp southp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the component name typo is fixed, this will be good to go on the launch day with the actual coupon code added :)

Desktop:
CleanShot 2024-11-25 at 18 49 37@2x

Mobile:
CleanShot 2024-11-25 at 18 49 51@2x

Tablet:
CleanShot 2024-11-25 at 18 51 36@2x


import './style.scss';

const Affiliates = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a typo. Maybe somethjing like BlackFriday2024?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!
Fixed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pls update the headline to "Our Biggest Sale..."

And also use this promo visual for the image: nNq0GqvlzdQ5i3OgusUon9-fi-249_65735

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrdnhllr Headline and promo visual have been updated.

@matticbot
Copy link
Contributor

matticbot commented Nov 26, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/black-friday-my-home-card on your sandbox.

@claudiucelfilip claudiucelfilip added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Nov 26, 2024
@a8ci18n
Copy link

a8ci18n commented Nov 26, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17020359

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@claudiucelfilip claudiucelfilip force-pushed the add/black-friday-my-home-card branch from 1208f84 to 94c1c19 Compare November 28, 2024 09:17
@claudiucelfilip claudiucelfilip merged commit e35a97b into trunk Nov 28, 2024
11 checks passed
@claudiucelfilip claudiucelfilip deleted the add/black-friday-my-home-card branch November 28, 2024 09:59
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 28, 2024
@a8ci18n
Copy link

a8ci18n commented Nov 28, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants