Hosting dashboard: Change the status filter to be primary

[allilevine]

Proposed Changes

• To address call for testing feedback (pdtkmj-2VB-p2#comment-5662) and previous design feedback that the "add filter" link is confusing and shouldn't show up, change the Status filter to be a "primary" filter. This does mean that "Status" will always be visible. An alternative solution would be to add another filter, like Plan.

Before	After

Why are these changes being made?

• To make filtering less confusing.

Testing Instructions

• Go to /sites
• Click to filter by status.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-121005

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-121005&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-121005&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/hosting-dashboard-add-filter-shows-up on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
staging-site              +13 B  (+0.0%)       +5 B  (+0.0%)
sites-dashboard           +13 B  (+0.0%)       +5 B  (+0.0%)
site-performance          +13 B  (+0.0%)       +5 B  (+0.0%)
site-monitoring           +13 B  (+0.0%)       +5 B  (+0.0%)
site-logs                 +13 B  (+0.0%)       +5 B  (+0.0%)
hosting-features          +13 B  (+0.0%)       +5 B  (+0.0%)
hosting                   +13 B  (+0.0%)       +5 B  (+0.0%)
github-deployments        +13 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[davemart-in]

Having "Status" there by default doesn't feel right. @jameskoster can you please help clarify what the default behavior is supposed to be here?

[jameskoster]

By default all filter chips are hidden until manually added by the user via the "Add filter" menu. The exception is primary filters which are added (unset) automatically and cannot be removed. It's a way of allowing users to bypass the "Add filter" menu so they can apply the most common filters quickly.

[allilevine]

By default all filter chips are hidden until manually added by the user via the "Add filter" menu. The exception is primary filters which are added (unset) automatically and cannot be removed. It's a way of allowing users to bypass the "Add filter" menu so they can apply the most common filters quickly.

Thank you! @davemart-in Should we put this on hold / look for another solution instead of showing "Status" by default?

[davemart-in]

@allilevine I'd probably side with closing this PR and keeping things the way they are.