Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Move comment input in reader-full-post view above related posts #95068

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

holdercp
Copy link
Contributor

@holdercp holdercp commented Oct 1, 2024

Fixes #94800

Proposed Changes

  • Move the comment input in the Reader full post view above related posts
Before After
Screenshot 2024-10-01 at 10 21 40 AM Screenshot 2024-10-01 at 10 20 37 AM

Why are these changes being made?

  • Improves the UX by grouping related posts together and moving the comment input closer to the post content.

Testing Instructions

  1. Go to /read and click on any post
  2. Scroll to bottom of post

Expected: Comment input should now be directly under the post actions and if related post sections are displayed, they should now be under the comments section.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@holdercp holdercp requested a review from a team as a code owner October 1, 2024 15:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 1, 2024
@holdercp holdercp self-assigned this Oct 1, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@holdercp holdercp requested a review from a team October 1, 2024 15:35
@holdercp
Copy link
Contributor Author

holdercp commented Oct 1, 2024

@davemart-in Just wanted to make sure you're aware that the two related posts sections are now stacked. I think it's still a better UI/UX than what was there before but wanted to call it out.

Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I don't mind the stacked recommendations since the first one is from your blog and the second on is from WordPress.com in general.

This looks ready to ship.

@holdercp holdercp merged commit e912558 into trunk Oct 1, 2024
15 checks passed
@holdercp holdercp deleted the update/move-comment-input-before-related-posts branch October 1, 2024 17:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The comment input is too far from the content
3 participants