Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Revamp Cancellation Flow (originally 93211) #95065

Merged
merged 11 commits into from
Oct 8, 2024

Conversation

sirbrillig
Copy link
Member

Proposed Changes

This PR refactors the purchase cancellation flow.

All the work was done originally by @Aurorum in #93211. This PR is just to move the branch to the calypso repo so that its strings can be translated (see #93211 (comment)).

@sirbrillig sirbrillig changed the title Purchases: Revamp Cancellation Flow (originally 93211) #94864 Purchases: Revamp Cancellation Flow (originally 93211) Oct 1, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions         -126 B  (-0.0%)      -17 B  (-0.0%)
entry-domains-landing       -126 B  (-0.0%)      -17 B  (-0.0%)
entry-browsehappy           -126 B  (-0.1%)      -17 B  (-0.0%)
entry-main                   +66 B  (+0.0%)       +7 B  (+0.0%)
entry-login                  +66 B  (+0.0%)      +21 B  (+0.0%)
entry-stepper                -42 B  (-0.0%)       -4 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~575 bytes removed 📉 [gzipped])

name            parsed_size           gzip_size
purchases           +2023 B  (+0.1%)     +185 B  (+0.0%)
site-purchases      +1523 B  (+0.1%)     +304 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~738 bytes removed 📉 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center       -524 B  (-0.1%)     -738 B  (-0.4%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug udpate/cancel-purchase-2 on your sandbox.

@sirbrillig sirbrillig self-assigned this Oct 1, 2024
@sirbrillig sirbrillig marked this pull request as ready for review October 1, 2024 15:07
@sirbrillig sirbrillig added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Oct 1, 2024
@a8ci18n
Copy link

a8ci18n commented Oct 1, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16889453

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @sirbrillig, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • This plan includes the custom domain mapping for %(mappedDomain)s. The domain will not be removed along with the plan, to avoid any interruptions for your visitors.
  • Your plan includes the custom domain {{strong}}%(domain)s{{/strong}}. What would you like to do with the domain?
  • By canceling the %(productName)s plan, these features will no longer be available on your site:
  • These features will no longer be available on your site when your %(productName)s plan expires:
  • After you confirm this change, the domain will be removed immediately.
  • After you confirm this change, the domain will be removed on %(expirationDate)s.
  • After you confirm this change, the subscription will be removed on %(expirationDate)s.
  • If you complete this cancellation, your subscription will be removed on {{span}}%(expirationDate)s{{/span}}.
  • Have a question or seeking a refund?
  • Need help with your purchase?
  • {{contactLink}}Ask a Happiness Engineer{{/contactLink}}.
  • Cancelling domain…
  • Cancel anyway
  • If you confirm this cancellation, you will receive a {{span}}refund of %(refundText)s{{/span}}, and your subscription will be removed immediately.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Oct 6, 2024

Translation for this Pull Request has now been finished.

@sirbrillig sirbrillig merged commit 0539f30 into trunk Oct 8, 2024
13 of 15 checks passed
@sirbrillig sirbrillig deleted the udpate/cancel-purchase-2 branch October 8, 2024 15:17
@github-actions github-actions bot removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants