Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: Add flow title when no pagetitle #95040

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

escapemanuele
Copy link
Contributor

Related to #

Proposed Changes

Add a default Create a site page title, similar to what's done in Start here

Why are these changes being made?

To add a page title to the page

image

Testing Instructions

  • Live link
  • Visit /setup/onboarding
  • Check that the Page title is Create a site
  • Visit /setup/sensei and check that it is Course Creator
  • Visit /setup/newsletter and check that it is Newsletter

@escapemanuele escapemanuele requested a review from a team as a code owner September 30, 2024 20:52
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 30, 2024
@escapemanuele escapemanuele requested a review from a team September 30, 2024 20:52
@escapemanuele escapemanuele self-assigned this Sep 30, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug stepper-page-title on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~18 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper        -41 B  (-0.0%)      -18 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@renancarvalho renancarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@escapemanuele escapemanuele merged commit f476f49 into trunk Oct 1, 2024
15 of 16 checks passed
@escapemanuele escapemanuele deleted the stepper-page-title branch October 1, 2024 09:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants