-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Apply the newly introduced location views API to the Locations module #95031
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~369 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me, but we might need to fix the unit test before merging 😄
Thanks for fixing this @dognose24! And kudos to @Automattic/jetpack-data-team 👍
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will filter the unknown locations first and ensure this change works well on Jetpack. |
Hi @dognose24 do you have any blockers for this one? |
Closing per discussion pejTkB-1Ic-p2 |
Related to p1727106755052629-slack-C82FZ5T4G, panfyZ-41e-p2#comment-10163
Proposed Changes
stats/country-views
API endpoint with the newly introducedstats/location-views/country
one, which would keep existing response data properties and eliminate unknown visit locations.Why are these changes being made?
Testing Instructions
Locations
module.Pre-merge Checklist