-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help Center: use Zendesk staging when proxied #94998
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Could you clarify a bit more the step 4?
|
I tested this in WP-ADMIN and get the production Zendesk when not proxied and the staging environment when proxied. |
7cb72ec
to
a8e353a
Compare
Testing in Calypso I get staging everywhere (local, live link). There is no way to test production other than deploying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise it is making sense to me, tested the testing steps and all works as described.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense, well done 👍
Related to https://github.com/Automattic/dotcom-forge/issues/9274
Proposed Changes
Why are these changes being made?
To limit the amount of calls made to production Zendesk. Specifically for testing and development.
Testing Instructions
/home
wpcomsupport.zendesk.com
at all.