Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: use Zendesk staging when proxied #94998

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

arcangelini
Copy link
Contributor

Related to https://github.com/Automattic/dotcom-forge/issues/9274

Proposed Changes

  • Change all configs to use staging zendesk except production.

Why are these changes being made?

To limit the amount of calls made to production Zendesk. Specifically for testing and development.

Testing Instructions

  1. Using the live link open /home
  2. Open your dev console and watch the network requests.
  3. Open Help Center and ensure we are not querying wpcomsupport.zendesk.com at all.
  4. Start a chat with Zendesk and ensure all calls are still to the staging environment and the widget that is loaded is green rather than blue.

@arcangelini arcangelini added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label Sep 27, 2024
@arcangelini arcangelini requested review from klimeryk and a team September 27, 2024 15:51
@arcangelini arcangelini self-assigned this Sep 27, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 27, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 27, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug zendesk-client/use-staging on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@renancarvalho
Copy link
Contributor

Could you clarify a bit more the step 4?

Start a chat with Zendesk and ensure all calls are still to the staging environment and the widget that is loaded is green rather than blue.

@arcangelini
Copy link
Contributor Author

I tested this in WP-ADMIN and get the production Zendesk when not proxied and the staging environment when proxied.

@arcangelini arcangelini force-pushed the zendesk-client/use-staging branch from 7cb72ec to a8e353a Compare October 1, 2024 08:42
@arcangelini
Copy link
Contributor Author

Testing in Calypso I get staging everywhere (local, live link). There is no way to test production other than deploying.

Copy link
Contributor

@renancarvalho renancarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it is making sense to me, tested the testing steps and all works as described.

LGTM 👍

@escapemanuele escapemanuele requested a review from a team October 1, 2024 09:04
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense, well done 👍

@arcangelini arcangelini merged commit 70dfaf5 into trunk Oct 1, 2024
11 checks passed
@arcangelini arcangelini deleted the zendesk-client/use-staging branch October 1, 2024 10:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants