A4A: Fix inconsistency with header spacing.

[jkguidaven]

This pull request standardizes the spacing in the A4A header layout. We have a couple of pages with different spacing, causing our page content to shift a lot. Example is the Overview page.

Before	After

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/805

Proposed Changes

• Remove the 'compact' layout variant, which has different spacing, and force all layout consumers to use the same spacing. We follow a 24px spacing for both the top and bottom.
• Remove some ad-hoc on some of the pages to force some consistency. We no longer need it as we are standardizing it from the core layout.

Why are these changes being made?

• Make our UI more polished, which results in a better user experience.

Testing Instructions

• Use the A4A live link and verify all headers have consistent spacing.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-120912

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-120912&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-120912&env=a8c-for-agencies

[jkguidaven]

Now that we are standardizing the spacing for all our headers, there is no longer a need for the compact variant in our layout.

[jkguidaven]

Lint is complaining about the maximum line length. I have to split it. though not related to the main goal of the PR

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~23 bytes removed 📉 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-marketplace              -94 B  (-0.0%)       -9 B  (-0.0%)
a8c-for-agencies-team                     -69 B  (-0.0%)       -5 B  (-0.0%)
a8c-for-agencies-client                   -36 B  (-0.0%)       -8 B  (-0.0%)
staging-site                              -25 B  (-0.0%)       -4 B  (-0.0%)
sites-dashboard                           -25 B  (-0.0%)       -4 B  (-0.0%)
site-performance                          -25 B  (-0.0%)       -4 B  (-0.0%)
site-monitoring                           -25 B  (-0.0%)       -4 B  (-0.0%)
site-logs                                 -25 B  (-0.0%)       -4 B  (-0.0%)
plugins                                   -25 B  (-0.0%)       -4 B  (-0.0%)
jetpack-cloud-plugin-management           -25 B  (-0.0%)       -4 B  (-0.0%)
hosting-features                          -25 B  (-0.0%)       -4 B  (-0.0%)
hosting                                   -25 B  (-0.0%)       -4 B  (-0.0%)
github-deployments                        -25 B  (-0.0%)       -4 B  (-0.0%)
a8c-for-agencies-sites                    -25 B  (-0.0%)       -3 B  (-0.0%)
a8c-for-agencies-settings                 -25 B  (-0.0%)       -3 B  (-0.0%)
a8c-for-agencies-referrals                -25 B  (-0.0%)       -3 B  (-0.0%)
a8c-for-agencies-plugins                  -25 B  (-0.0%)       -3 B  (-0.0%)
a8c-for-agencies-partner-directory        -25 B  (-0.0%)       -3 B  (-0.0%)
a8c-for-agencies-overview                 -25 B  (-0.0%)       -3 B  (-0.0%)
a8c-for-agencies-migrations               -25 B  (-0.0%)       -3 B  (-0.0%)
a8c-for-agencies-landing                  -25 B  (-0.0%)       -3 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[cleacos]

Now, all the header sections are consistent.

As Tiago already said, in the Overview section, the content top padding seems small.

Other than that LGTM!

[jkguidaven]

Now, all the header sections are consistent.

As Tiago already said, in the Overview section, the content top padding seems small.

Other than that LGTM!

Thanks. The Overview section top padding has been fixed along with other pages.