Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Include delisted when searching #94846

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Sep 24, 2024

Closes #94310.

Before After
image image

Why are these changes being made?

Delisted themes were not being included in search, causing a mismatch with the Dotorg API and categorizing some free themes as 3rd-party that requires a paid site.

Testing Instructions

  1. Apply D162217-code and proxy your sandbox
  2. Search for 2011 and eleven and make sure it shows up as a free theme instead of requiring an Upgrade

@zaguiini zaguiini added [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. Groundskeeping Issues handled through Dotcom Groundskeeping rotations labels Sep 24, 2024
@zaguiini zaguiini requested a review from dsas September 24, 2024 11:38
@zaguiini zaguiini self-assigned this Sep 24, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 24, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug themes/include-delisted-when-searching on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~12 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
themes                         +12 B  (+0.0%)       +4 B  (+0.0%)
theme                          +12 B  (+0.0%)       +4 B  (+0.0%)
readymade-template-flow        +12 B  (+0.0%)       +3 B  (+0.0%)
marketplace                    +12 B  (+0.0%)       +4 B  (+0.0%)
checkout                       +12 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~4 bytes added 📈 [gzipped])

name                                     parsed_size           gzip_size
async-load-signup-steps-theme-selection        +12 B  (+0.0%)       +4 B  (+0.0%)
async-load-design-blocks                       +12 B  (+0.0%)       +4 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me for the twentyeleven theme. The behaviour in general matches the FG now (PCYsg-S9k-p2).

CC @Automattic/lego as the people who worked on delisting originally.

@zaguiini zaguiini requested a review from a team September 24, 2024 22:49
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zaguiini zaguiini merged commit c272015 into trunk Sep 25, 2024
16 of 17 checks passed
@zaguiini zaguiini deleted the themes/include-delisted-when-searching branch September 25, 2024 12:11
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 25, 2024
taipeicoder added a commit that referenced this pull request Nov 26, 2024
taipeicoder added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. Groundskeeping Issues handled through Dotcom Groundskeeping rotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twenty Twenty themes are showing up as upgrade required
4 participants