-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme tooltips: sets specific messaging for ecommerce trial plans. #94812
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
@candy02058912 my approach here is to create different messaging depending on if the site is on trial plan or not, and explaining that those themes are not available in trial plans. What do you think? |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~240 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~115 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The proposed changes look good and work as expected. The tooltip messages render correctly and the links lead to the checkout page with relevant plans added to the cart.
Partner theme | Community theme |
---|---|
Tested with different plans and did not observe any regressions, errors nor warnings.
Approving the PR with two small thoughts:
- I think we could ask designers for input / confirmation on the new copy.
- The new translations won't be ready yet. → We could consider adding checks and only display new strings once their translation is ready. However, considering that the current copy in production is incorrect, I think we could skip this step and let the tooltips display in English until they get translated.
Thanks for the ping @cpapazoglou. How about this for the copy instead: Community Partner |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16880624 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @cpapazoglou, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Fixes #94748
Proposed Changes
Community
This community theme cannot be installed in a trial plan site. Please upgrade your Commerce plan on your site.
Partner
This theme costs %(annualPrice)s per year or %(monthlyPrice)s per month, and cannot be purchased in a trial plan site. Please upgrade your Commerce plan on your site.
Testing Instructions
Commerce Trial Plan
On a plan lower than business
Pre-merge Checklist