Stepper: Record calypso_signup_start unconditionally => multiple logs

[chriskmnds]

Related to #94175
Fixes #94717

Proposed Changes

Records calypso_signup_start event unconditionally. This means it can get logged not only on the first step but on any of the dependencies changing.

extraProps coming from useSignupStartEventProps are guaranteed now to be logged as they change through flow progression.

Why are these changes being made?

Addressed #94175 (comment)

Testing Instructions

• Go to /setup/onboarding
• Ensure you see calypso_signup_start being recorded when logging in and on refreshing the page

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-72d2f2428303245050f990524645edbe648d29da

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-72d2f2428303245050f990524645edbe648d29da&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-72d2f2428303245050f990524645edbe648d29da&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~93 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper       -198 B  (-0.0%)      -93 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[escapemanuele]

Tested it and the event is triggered with every refresh 👍

[renancarvalho]

This is working fine!

I got confused, is this the same as this? If so, I think I can close my PR then?

[escapemanuele]

@chriskmnds just noting that this PR will also fix this comment, since elapsed_time_since_start on calypso_signup_complete is now null if calypso_signup_start is not triggered ✌️

@renancarvalho yes, as pointed out in your PR 👍

[chriskmnds]

This is working fine!

I got confused, is this the same as this? If so, I think I can close my PR then?

@renancarvalho It's something like part of a long story we've been drilling around for a few weeks #94175 (and related PR #94248 )

It is an alternative to your PR (and any other approach that ignores dependencies like "extra props" from retriggering the event), so if we ship this then we can close yours. Shipping this means also closing @gabrielcaires' PR: #94248

I want to get everyone involved/aware around #94175 so nobody's surprised if multiple events triggering show up in discussions. I intend to follow up similarly with other events :-)

@chriskmnds just noting that this PR will also fix #94706 (review), since elapsed_time_since_start on calypso_signup_complete is now null if calypso_signup_start is not triggered ✌️

Thanks @escapemanuele! Cool :D

[chriskmnds]

Thank you all for reviewing! and for buying into this idea of "unconditional tracking" 🙈
Merging, and grabbing #94767 to address next