Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Increase the filter selector height to show part of the next item #94588

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

tiagonoronha
Copy link
Contributor

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1080

Proposed Changes

  • Increase the filter selector height to show part of the next item, indicating more options.
Screenshot 2024-09-16 at 18 04 27

Testing Instructions

  • Open the live link
  • Go to Sites.
  • Toggle the filter display view
  • Click "Status"
  • Confirm you see half of the next (hidden) item in the popover.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@tiagonoronha tiagonoronha requested a review from a team September 16, 2024 17:06
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 16, 2024
@tiagonoronha tiagonoronha changed the title Increase the filter selector height to show part of the next item A4A: Increase the filter selector height to show part of the next item Sep 16, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug a4a/fix/status-filter-height on your sandbox.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels more intuitive now. LGTM!

@tiagonoronha tiagonoronha merged commit bd4f154 into trunk Sep 17, 2024
14 of 15 checks passed
@tiagonoronha tiagonoronha deleted the a4a/fix/status-filter-height branch September 17, 2024 08:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants