Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Skip long-failing VideoPress test #94584

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Sep 16, 2024

Proposed Changes

Skip the "Media (Upload): Populate post with media blocks: VideoPress block: upload video file" test.

Why are these changes being made?

We've been muting this since February, and the failure seems to be specific to the test sites. Time to just .skip it until the team gets a chance to fix it.

Testing Instructions

  • Run the test against Jetpackedge sites. Passes, with the VideoPress test skipped.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

We've been muting this since February, and the failure seems to be
specific to the test sites. Time to just `.skip` it until the team gets
a chance to fix it.
@anomiex anomiex requested a review from a team September 16, 2024 15:24
@anomiex anomiex self-assigned this Sep 16, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 16, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@mashikag mashikag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @anomiex! 🙇

@anomiex anomiex merged commit 0415f3b into trunk Sep 16, 2024
13 checks passed
@anomiex anomiex deleted the fix/skip-long-failing-videpress-e2e-test branch September 16, 2024 15:41
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants